drivers: udc_dwc2: Add nRF54LM20A vendor quirks #92842
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial implementation of nRF54L quirks necessary for nRF54LM20A. Signed-off-by: Tomasz Moń <[email protected]> Signed-off-by: Johann Fischer <[email protected]>
jfischer-no
added
area: Drivers
area: USB
|
cvinayak
reviewed
Jul 16, 2025
| #include <zephyr/drivers/clock_control.h> | ||
| #include <zephyr/drivers/clock_control/nrf_clock_control.h> | ||
|
|
||
| #define NRF_DEFAULT_IRQ_PRIORITY 1 |
There was a problem hiding this comment.
Suggested change
| #define NRF_DEFAULT_IRQ_PRIORITY 1 |
Comment on lines
+358
to
+359
| IRQ_CONNECT(VREGUSB_IRQn, NRF_DEFAULT_IRQ_PRIORITY, | ||
| vregusb_isr, DEVICE_DT_INST_GET(0), 0); |
There was a problem hiding this comment.
Why use NRF_DEFAULT_IRQ_PRIORITY? Why not from devicetree (node) ?
There was a problem hiding this comment.
There is no devicetree node for VREGUSB peripheral (there is devicetree for USBHS peripheral, but it is VREGUSB that is used here in vendor quirk).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of nRF54L quirks necessary for nRF54LM20A.