drivers: dma_mcux_edma: Simple Refactoring #92869
Open
+361
−326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: DMA
github-actions
bot
requested review from
dbaluta,
dleach02,
manuargue,
mmahadevan108,
Raymond0225 and
teburd
|
@decsny it does not well on my mimxrt1060_evk@c platform. and for uart tests/drivers/uart/uart_async_api/drivers.uart.async_api.lpuart.rt_nocache |
|
@hakehuang it looks like there was a typo in a #if condition which affected platform with cache like RT1060, should be fixed now |
@decsny now regression pass on v4.2.0-rc3-26-g6aea2db65c32, but need fix issue with |
hakehuang
previously approved these changes
Jul 17, 2025
|
@decsny please address the CI issues |
|
i will when i have time |
The dependency on the chosen node for dtcm can be expressed in Kconfig language. Cache we care about is CPU DCACHE, not the meaningless "MCUX Cache" The macros can be reordered to be simpler by having only one level of conditional (no nesting) instead of three levels. Move this code closer in the file to where this cache attribute macro is actually going to be used (the init macro) instead of randomly splitting up the struct definitions at the top. Signed-off-by: Declan Snyder <[email protected]>
One #ifdef outside the functions is simpler to read than two #ifdefs inside the functions. Signed-off-by: Declan Snyder <[email protected]>
Instead of having preprocessor code, make a hidden kconfig to indicate this and be smarter about the C code (these are all powers of two) Signed-off-by: Declan Snyder <[email protected]>
There is two completely different types of reload modes happening here, therefore we should split this function into two completely separate functions because it was getting large and hard to read. Removes one level of indentation. Signed-off-by: Declan Snyder <[email protected]>
There was actually three different types of configuration modes happening here, and this function was getting extremely bulky and hard to read due to the amount of nesting of conditionals. Split these into separate functions and call them appropriately depending on the type of transfer. Signed-off-by: Declan Snyder <[email protected]>
Extract and group dmamux related code together for readability. Signed-off-by: Declan Snyder <[email protected]>
Halve all this ifdef code by making a macro function for the memory mapping. Signed-off-by: Declan Snyder <[email protected]>
|
|
@hakehuang can you help retesting this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This edma driver is extremely important for NXP platforms as it is used by many different drivers itself, and what I am noticing is that is always causing a lot of problems to debug through it because it is a mess. So this PR is doing a basic refactor which should not change any logic of the program flow but just splitting things into helper functions to be more readable, etc.