-
Notifications
You must be signed in to change notification settings - Fork 7.8k
drivers: spi: spi_context: exclude gpio code if no gpio cs #92888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maass-hamburg
wants to merge
2
commits into
zephyrproject-rtos:main
Choose a base branch
from
maass-hamburg:spi_context_no_gpio
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
drivers: spi: spi_context: exclude gpio code if no gpio cs #92888
maass-hamburg
wants to merge
2
commits into
zephyrproject-rtos:main
from
maass-hamburg:spi_context_no_gpio
+34
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77d4673
to
bd52723
Compare
bd52723
to
cc0f25b
Compare
tbursztyka
reviewed
Aug 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rebase it.
Seems ok to me, though perhaps it could reduce the amount of ifdefs by doing so:
#ifndef DT_SPI_CTX_HAS_NO_CS_GPIOS
... declare all the gpio cs functions asdoing nothing ...
# else
... the current function doing gpio cs stuff ...
#endif
cc0f25b
to
c015372
Compare
pdgendt
reviewed
Aug 8, 2025
c015372
to
44632c7
Compare
|
exclude gpio code if no gpio cs are used for that spi driver. Signed-off-by: Fin Maaß <[email protected]>
remove spi_cs_is_gpio checks before spi_context_cs_control, as it is also done inside and we don't need to check two times. Signed-off-by: Fin Maaß <[email protected]>
44632c7
to
01b85b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: SPI
SPI bus
platform: ESP32
Espressif ESP32
platform: ITE
ITE
platform: Nuvoton Numicro Numaker
Nuvoton Technology Corporation, Numicro Numaker
platform: STM32
ST Micro STM32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exclude gpio code if no gpio cs are used
for that spi driver. Because all of it is in a header and all functions and definitions are inline, we can optimize code out during build