Skip to content

boards: add axp2101-fuel-gauge to all boards with an AXP2101 PMIC #93155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2025

Conversation

kartben
Copy link
Contributor

@kartben kartben commented Jul 15, 2025

Multi-function PMIC AXP2101 now has a fuel gauge driver. Add the corresponding node to all boards with such a PMIC (also checked their datasheets and confirmed these actually have a battery correctly connected to the PMIC).

First commit fixes CI issues in drivers/counter/counter_basic_api tests for the modified boards and that can be observed in weekly Twister runs (https://github.com/zephyrproject-rtos/zephyr/actions/runs/16395283708)

cc @fmoessbauer

@kartben kartben force-pushed the axp2101-fuel-gauge branch 2 times, most recently from ae675f1 to 8da26d2 Compare July 16, 2025 11:46
@zephyrbot zephyrbot requested a review from nordic-krch July 17, 2025 02:47
@kartben kartben force-pushed the axp2101-fuel-gauge branch from 8da26d2 to bd362a5 Compare July 22, 2025 09:08
kartben added 2 commits July 22, 2025 12:19
The use of timer3 seems to be some legacy leftover from when the
overlay was specific to esp32s3_devkitm originally (commit cf3b264).
Using timer0 instead.

Signed-off-by: Benjamin Cabé <[email protected]>
Multi-function PMIC AXP2101 now has a fuel gauge driver. Add the
corresponding node to all boards with such a PMIC (also checked their
datasheets and confirmed these actually have a battery correctly
connected to the PMIC).

Signed-off-by: Benjamin Cabé <[email protected]>
@kartben kartben force-pushed the axp2101-fuel-gauge branch from bd362a5 to 2904fcb Compare July 22, 2025 10:19
Copy link

@kartben kartben marked this pull request as ready for review July 22, 2025 11:03
@kartben kartben requested review from teburd, aaronemassey and DBS06 July 22, 2025 12:00
@kartben kartben assigned teburd and aaronemassey and unassigned nordic-krch Jul 22, 2025
Copy link
Contributor

@DBS06 DBS06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done 👍

@kartben
Copy link
Contributor Author

kartben commented Jul 22, 2025

I should mention that I've tested it on the T-Watch, btw :)
PXL_20250722_132813385

@DBS06
Copy link
Contributor

DBS06 commented Jul 22, 2025

I should mention that I've tested it on the T-Watch, btw :)
PXL_20250722_132813385

Nice 👍

To be honest, I didn't expect anything else from you 😉

The only thing I am missing for the fuel_gauge_axp2101 is an emulation and unit test, but this is not the scope of this PR.

@cfriedt
Copy link
Member

cfriedt commented Jul 29, 2025

I should mention that I've tested it on the T-Watch, btw :)

I think I need to buy one of these now 😅

@cfriedt cfriedt merged commit bb92d71 into zephyrproject-rtos:main Jul 29, 2025
31 checks passed
@kartben
Copy link
Contributor Author

kartben commented Jul 29, 2025

I should mention that I've tested it on the T-Watch, btw :)

I think I need to buy one of these now 😅

@cfriedt wait for this one to be in stock, maybe? :)
https://lilygo.cc/products/t-watch-ultra?variant=51364248191157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants