-
Notifications
You must be signed in to change notification settings - Fork 7.7k
board: nrf: Fix nRF54LM20DK upstream Bluetooth Controller supported #93194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
board: nrf: Fix nRF54LM20DK upstream Bluetooth Controller supported #93194
Conversation
Fix nRF54LM20DK upstream Bluetooth Controller supported. Relates to commit 3d1fa8b ("board: nrf: Add nRF54LM20DK board"). Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes Bluetooth Controller support for the nRF54LM20DK board by switching from the proprietary SoftDevice Controller (SDC) to the upstream Bluetooth Controller implementation. This change aligns the board configuration with upstream Zephyr Bluetooth standards.
- Switches from
bt_hci_sdc
(SoftDevice Controller) tobt_hci_controller
(upstream controller) in board configuration - Adds nRF54LM20DK support to HCI UART Bluetooth samples with appropriate test configurations
- Includes board-specific overlay files for UART and direction finding (DF) configurations
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
boards/nordic/nrf54lm20dk/nrf54lm20a_cpuapp_common.dtsi | Updates Bluetooth HCI reference from SDC to upstream controller |
boards/nordic/nrf54lm20dk/nrf54lm20dk_nrf54lm20a_cpuapp.dts | Enables upstream Bluetooth controller and removes SDC configuration |
samples/bluetooth/hci_uart/sample.yaml | Adds nRF54LM20DK platform support and test configuration |
samples/bluetooth/hci_uart/boards/nrf54lm20dk_nrf54lm20a_cpuapp.overlay | Provides basic UART configuration for the board |
samples/bluetooth/hci_uart/boards/nrf54lm20dk_nrf54lm20a_cpuapp_df.overlay | Adds direction finding support with antenna matrix configuration |
- nrf54lm20dk/nrf54lm20a/cpuapp | ||
extra_args: | ||
- EXTRA_CONF_FILE=overlay-all-bt_ll_sw_split.conf | ||
- DTC_OVERLAY_FILE=./boards/nrf54lm20dk_nrf54lm20a_cpuapp_df.overlay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't the /boards/nrf54lm20dk_nrf54lm20a_cpuapp_df.overlay
be automatically applied when building?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a board revision / qualifier nrf54lm20dk/nrf54lm20a/cpuapp
then boards/nrf54lm20dk_nrf54lm20a_cpuapp.overlay
is picked.
I tried west build samples/bluetooth/hci_uart -b nrf54lm20dk/nrf54lm20a/cpuapp@df -- -DEXTRA_CONF_FILE=overlay-all-bt_ll_sw_split.conf
does not build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, missed the _df
part :)
Fix nRF54LM20DK upstream Bluetooth Controller supported.
Relates to commit 3d1fa8b ("board: nrf: Add nRF54LM20DK board").