net: tcp: Fix handling of keep-alive probes #93431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep-alive probes have seq number set to SND.NXT - 1 and may or may not contain an octet of data. The latter case was not handled properly therefore add a special case when validating seq number to response to keep-alive probes. Signed-off-by: Robert Lubos <[email protected]>
Add test verifying that if keep-alive messages are exchanged, the connection remains alive. Signed-off-by: Robert Lubos <[email protected]>
|
CC @shrek-wang |
1 task
|
jukkar
approved these changes
Jul 21, 2025
|
ping @pdgendt |
I'm not super familiar with the TCP stack, so was hoping others could chime in. @lucasdietrich can you confirm that this fixes your issue? |
The reviewer list is short on this one so just trying to get this moving forward 😄 |
Yes, I can confirm that the patch fixes my issue. Thanks! |
pdgendt
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix processing of a received keep-alive probe and add a test case that the connection remains alive after a keep-alive exchange.
Fixes #93350