Skip to content

manifest: Microchip HAL PIC32CXSG updates #93684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

MyGh64605
Copy link
Contributor

These are updates required from reviewers of PR #86952

These are updates required from reviewers of PR zephyrproject-rtos#86952

Signed-off-by: Michael Sherwood <[email protected]>
@zephyrbot zephyrbot added the size: XS A PR changing only a single line of code label Jul 24, 2025
Copy link

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_microchip zephyrproject-rtos/hal_microchip@32a79d4 zephyrproject-rtos/hal_microchip@29f8e60 zephyrproject-rtos/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

Copy link

@MyGh64605
Copy link
Contributor Author

@nandojve Please assign a couple reviewer for this PR - manifest: Microchip HAL PIC32CXSG updates #93684.
I do not get the option to assign reviewers.

@nordicjm
Copy link
Contributor

this is part of the PR? I don't get why this was opened separately as another PR

@MyGh64605
Copy link
Contributor Author

@nordicjm @scottwcpg @TheSilverBB @nandojve
Since a reviewer requested that we change the snakecase 'RoReg' to 'ro_reg and to remove any dependencies with Zephyr, the requested changes were made in hal_microchip/pic32c/pic32cxsg.

@MyGh64605
Copy link
Contributor Author

@nordicjm @scottwcpg @TheSilverBB @nandojve @erwango @MaureenHelm

nordicjm asked this question:
"this is part of the PR? I don't get why this was opened separately as another PR"

My response:
"Since a reviewer requested that we change the snakecase 'RoReg' to 'ro_reg and to remove any dependencies with Zephyr, the requested changes were made in hal_microchip/pic32c/pic32cxsg."

@nandojve
Copy link
Member

@nordicjm @scottwcpg @TheSilverBB @nandojve @erwango @MaureenHelm

nordicjm asked this question: "this is part of the PR? I don't get why this was opened separately as another PR"

My response: "Since a reviewer requested that we change the snakecase 'RoReg' to 'ro_reg and to remove any dependencies with Zephyr, the requested changes were made in hal_microchip/pic32c/pic32cxsg."

Hi @MyGh64605 ,

As mention, this is part of that PR and should not be make mainline without that part.
You should create a PR inside hal_microchip and then link that PR in the #86952 as first commit with

-      revision: 32a79d481c056b2204a5701d5a5799f9e5130dd7
+      revision: pull/34/head

When the #86952 is ready to go (not before) we merge the content in the hal_microchip and update the PR with latest hash.
Otherwise MCHP may have problems to go back and forward with hal hash. The other problem is that you are adding content in the hal and don't know if even the code compiles. You need a target (board) inside Zephyr to make sure code compile and runs.

CC: @NhMchp, @sunil-abraham

@MyGh64605
Copy link
Contributor Author

@nandojve @NhMchp @sunil-abraham Moving this commit to PR #86952 at the request of the code reviewers on that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manifest manifest-hal_microchip size: XS A PR changing only a single line of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants