Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rem()
and@mod()
state that the caller must guaranteedenominator > 0
, when it is actuallydenominator != 0
, which is what it's changed to. (closes@rem
and@mod
langref documentation is wrong #23635)Regarding 3. I also wanted to ensure the new langrefs would stay correct, so I looked if
denominator < 0
is tested anywhere. For@mod()
it is already tested, for@rem()
not, so I added those tests.I hope I added them in the correct file, if not I can change it.