generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 125
Glasgow | May-2025 | Mansoor Munawar | Sprint 2 | Book library #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MansoorM11
wants to merge
11
commits into
CodeYourFuture:main
Choose a base branch
from
MansoorM11:book-library-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7373cdb
Fix book submission logic and improve render function; add live serve…
MansoorM11 3af9173
Remove unnecessary render call in populateStorage function
MansoorM11 e288ff5
Fix book page count type in populateStorage function
MansoorM11 39444d7
Fix book pages value type in populateStorage function
MansoorM11 dcd06c6
Refactor submit function to use ternary statment.
MansoorM11 584176d
Rename input variable constants for clarity
MansoorM11 3809f61
Refactor submit function to improve readability and use consistent va…
MansoorM11 d883baa
Refactor read status assignment in render function to use ternary ope…
MansoorM11 a1b43bd
Fix HTML structure and input types for title and author fields
MansoorM11 2b070dc
Refactor submit function for better performance and improve input va…
MansoorM11 e84f17c
Refactor render function to improve button naming consistency and sim…
MansoorM11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"liveServer.settings.port": 5503 | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ window.addEventListener("load", function (e) { | |
|
||
function populateStorage() { | ||
if (myLibrary.length == 0) { | ||
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); | ||
let book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true); | ||
let book2 = new Book( | ||
"The Old Man and the Sea", | ||
"Ernest Hemingway", | ||
|
@@ -16,7 +16,6 @@ function populateStorage() { | |
); | ||
myLibrary.push(book1); | ||
myLibrary.push(book2); | ||
render(); | ||
} | ||
} | ||
|
||
|
@@ -28,18 +27,18 @@ const check = document.getElementById("check"); | |
//check the right input from forms and if its ok -> add the new book (object in array) | ||
//via Book function and start render function | ||
function submit() { | ||
if ( | ||
title.value == null || | ||
title.value == "" || | ||
pages.value == null || | ||
pages.value == "" | ||
) { | ||
if (!title.value.trim() || !author.value.trim() || !pages.value.trim()) { | ||
alert("Please fill all fields!"); | ||
return false; | ||
} else { | ||
let book = new Book(title.value, title.value, pages.value, check.checked); | ||
library.push(book); | ||
let book = new Book(title.value, author.value, pages.value, check.checked); | ||
myLibrary.push(book); | ||
render(); | ||
//clear user input data after storing the information | ||
title.value = ""; | ||
author.value = ""; | ||
pages.value = ""; | ||
check.checked = false; | ||
} | ||
} | ||
|
||
|
@@ -54,7 +53,7 @@ function render() { | |
let table = document.getElementById("display"); | ||
let rowsNumber = table.rows.length; | ||
//delete old table | ||
for (let n = rowsNumber - 1; n > 0; n-- { | ||
for (let n = rowsNumber - 1; n > 0; n--) { | ||
table.deleteRow(n); | ||
} | ||
//insert updated row and cells | ||
|
@@ -77,9 +76,9 @@ function render() { | |
wasReadCell.appendChild(changeBut); | ||
let readStatus = ""; | ||
if (myLibrary[i].check == false) { | ||
readStatus = "Yes"; | ||
} else { | ||
readStatus = "No"; | ||
} else { | ||
readStatus = "Yes"; | ||
} | ||
changeBut.innerText = readStatus; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This could be a good opportunity to practice using the |
||
|
||
|
@@ -90,11 +89,11 @@ function render() { | |
|
||
//add delete button to every row and render again | ||
let delButton = document.createElement("button"); | ||
delBut.id = i + 5; | ||
deleteCell.appendChild(delBut); | ||
delBut.className = "btn btn-warning"; | ||
delBut.innerHTML = "Delete"; | ||
delBut.addEventListener("clicks", function () { | ||
delButton.id = i + 5; | ||
deleteCell.appendChild(delButton); | ||
delButton.className = "btn btn-warning"; | ||
delButton.innerHTML = "Delete"; | ||
delButton.addEventListener("click", function () { | ||
alert(`You've deleted title: ${myLibrary[i].title}`); | ||
myLibrary.splice(i, 1); | ||
render(); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change one and not the other?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i totally missed that. Thanks for letting me know