Glasgow | May-2025 | Mansoor Munawar | Sprint 2 | Book library #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MansoorM11
added
the
Needs Review
cjyuan
reviewed
Aug 20, 2025
| @@ -7,7 +7,7 @@ window.addEventListener("load", function (e) { | |||
|
|
|||
| function populateStorage() { | |||
| if (myLibrary.length == 0) { | |||
| let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); | |||
| let book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true); | |||
There was a problem hiding this comment.
Why change one and not the other?
There was a problem hiding this comment.
i totally missed that. Thanks for letting me know
debugging/book-library/script.js
Outdated
Comment on lines
77
to
83
| let readStatus = ""; | ||
| if (myLibrary[i].check == false) { | ||
| readStatus = "Yes"; | ||
| } else { | ||
| readStatus = "No"; | ||
| } else { | ||
| readStatus = "Yes"; | ||
| } | ||
| changeBut.innerText = readStatus; |
There was a problem hiding this comment.
This could be a good opportunity to practice using the ? : conditional operator. Can you rewrite the code on lines 77-83 as a single statement?
cjyuan
added
Reviewed
MansoorM11
added
Needs Review
cjyuan
reviewed
Aug 21, 2025
There was a problem hiding this comment.
According to https://validator.w3.org/, there are errors in your index.html. Can you fix these errors?
debugging/book-library/script.js
Outdated
Comment on lines
31
to
45
| !titleInput.value.trim() || | ||
| !authorInput.value.trim() || | ||
| !pagesInput.value.trim() | ||
| ) { | ||
| alert("Please fill all fields!"); | ||
| return false; | ||
| } else { | ||
| let book = new Book(title.value, title.value, pages.value, check.checked); | ||
| library.push(book); | ||
| myLibrary.push( | ||
| new Book( | ||
| titleInput.value.trim(), | ||
| authorInput.value.trim(), | ||
| Number(pagesInput.value), | ||
| checkInput.checked | ||
| ) | ||
| ); |
There was a problem hiding this comment.
-
For better performance (reduce number of function calls) and reducing the chance of using raw input accidently, we could stored the pre-processed/sanitized/normalized input in some variables first, and reference the variables in other part of the function.
-
pagesInput.valuecould be a value like "3.1416".
debugging/book-library/script.js
Outdated
Comment on lines
97
to
98
| let deleteBtn = document.createElement("button"); | ||
| deleteBtn.id = i + 5; |
There was a problem hiding this comment.
- Variable name is still not consistent
- Value assigned to the
idattribute is not unique (when there are more than 5 books), and what is the use of theidattribute in this application?
cjyuan
added
Reviewed
MansoorM11
added
Needs Review
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
Briefly explain your PR.
fixed the bugs in book library and refactor code to meet the requirements of the task. And also used "https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md" to improve my code
Questions
Ask any questions you have for your reviewer.