Skip to content

Glasgow | May-2025 | Mansoor Munawar | Sprint 2 | Book library #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Glasgow | May-2025 | Mansoor Munawar | Sprint 2 | Book library #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7373cdb
Fix book submission logic and improve render function; add live serve…
MansoorM11 Aug 20, 2025
3af9173
Remove unnecessary render call in populateStorage function
MansoorM11 Aug 20, 2025
e288ff5
Fix book page count type in populateStorage function
MansoorM11 Aug 20, 2025
39444d7
Fix book pages value type in populateStorage function
MansoorM11 Aug 20, 2025
dcd06c6
Refactor submit function to use ternary statment.
MansoorM11 Aug 20, 2025
584176d
Rename input variable constants for clarity
MansoorM11 Aug 20, 2025
3809f61
Refactor submit function to improve readability and use consistent va…
MansoorM11 Aug 20, 2025
d883baa
Refactor read status assignment in render function to use ternary ope…
MansoorM11 Aug 20, 2025
a1b43bd
Fix HTML structure and input types for title and author fields
MansoorM11 Aug 21, 2025
2b070dc
Refactor submit function for better performance and improve input va…
MansoorM11 Aug 21, 2025
e84f17c
Refactor render function to improve button naming consistency and sim…
MansoorM11 Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"liveServer.settings.port": 5503
}
15 changes: 6 additions & 9 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<title>My Book Library</title>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
Expand All @@ -31,15 +28,15 @@ <h1>Library</h1>
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
type="text"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
type="text"
class="form-control"
id="author"
name="author"
Expand Down
74 changes: 38 additions & 36 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,40 +7,49 @@ window.addEventListener("load", function (e) {

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change one and not the other?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i totally missed that. Thanks for letting me know

let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");
const titleInput = document.getElementById("title");
const authorInput = document.getElementById("author");
const pagesInput = document.getElementById("pages");
const checkInput = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
const titleValue = titleInput.value.trim();
const authorValue = authorInput.value.trim();
const pagesValue = pagesInput.value.trim();
const pagesNumber = Number(pagesValue);
const isRead = checkInput.checked;
if (!titleValue || !authorValue || !pagesValue) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
}
if (!Number.isInteger(pagesNumber) || pagesNumber <= 0) {
alert("Pages can be only whole number greater than 0!");
return false;
}

myLibrary.push(new Book(titleValue, authorValue, pagesNumber, isRead));

render();
//clear user input data after storing the information
titleInput.value = "";
authorInput.value = "";
pagesInput.value = "";
checkInput.checked = false;
return true;
}

function Book(title, author, pages, check) {
Expand All @@ -54,7 +63,7 @@ function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
for (let n = rowsNumber - 1; n > 0; n--) {
table.deleteRow(n);
}
//insert updated row and cells
Expand All @@ -71,30 +80,23 @@ function render() {
pagesCell.innerHTML = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
let toggleReadButton = document.createElement("button");
toggleReadButton.className = "btn btn-success";
wasReadCell.appendChild(toggleReadButton);
let readStatus = myLibrary[i].check ? "Yes" : "No";
toggleReadButton.innerText = readStatus;

changeBut.addEventListener("click", function () {
toggleReadButton.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
let deleteButton = document.createElement("button");
deleteCell.appendChild(deleteButton);
deleteButton.className = "btn btn-warning";
deleteButton.innerHTML = "Delete";
deleteButton.addEventListener("click", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
render();
Expand Down