feature: add new reduction valop / valloc interface to kernel #1799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LLNL/raja-core It would be nice to get a preliminary review on this PR. I'm still working on the openmp implementation of this feature, but HIP and CUDA are passing the basic unit tests demonstrated in the PR |
|
@johnbowen42 , I took a look -- Overall its looking pretty good! My one comment is that we should add 2 lambda test just to verify that works as well. |
… into feature/bowen/add-valop-kernel
|
@johnbowen42 would also be able to add the kernel naming capability? It should be copy paste from one of the forall or launch implementations |
artv3
reviewed
May 22, 2025
artv3
reviewed
May 22, 2025
artv3
approved these changes
May 22, 2025
MrBurmark
reviewed
May 23, 2025
MrBurmark
reviewed
May 23, 2025
MrBurmark
reviewed
May 23, 2025
johnbowen42
commented
May 23, 2025
MrBurmark
reviewed
May 23, 2025
MrBurmark
reviewed
May 23, 2025
test/functional/kernel/reduce-params-multi-lambda/test-kernel-reduce-params-multi-lambda.cpp.in
Outdated
Show resolved
Hide resolved
MrBurmark
reviewed
May 23, 2025
test/functional/kernel/reduce-params-multi-lambda/test-kernel-reduce-params-multi-lambda.cpp.in
Show resolved
Hide resolved
… into feature/bowen/add-valop-kernel
|
resolves #1522 |
rchen20
reviewed
May 29, 2025
rchen20
approved these changes
May 30, 2025
MrBurmark
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the
RAJA::expt::Reduceinterface to work inside RAJA::kernels. See examples/kernel-reduction.cpp for an example