Skip to content

feature: add new reduction valop / valloc interface to kernel #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 47 commits into from
May 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
de346d9
Add kernel reduction example
johnbowen42 Jan 18, 2025
6c14d93
sequential reduction kernels working
johnbowen42 Feb 20, 2025
978e2ac
add example
johnbowen42 Feb 20, 2025
245d5a2
Merge branch 'develop' into feature/bowen/add-valop-kernel
johnbowen42 Feb 20, 2025
6c5ee06
Basic reductions working
johnbowen42 Feb 27, 2025
7ae37ed
Merge branch 'develop' into feature/bowen/add-valop-kernel
johnbowen42 Feb 27, 2025
9e7031b
Cuda kernel reduction example working
johnbowen42 Feb 28, 2025
94c9a99
reformat and fix examples
johnbowen42 Mar 4, 2025
33a2afb
Fix namespace errors
johnbowen42 Mar 5, 2025
d626946
remove hip changes temporarily
johnbowen42 Mar 5, 2025
516a418
add basic unit testing
johnbowen42 Mar 5, 2025
dc8ec52
Change hip kernel
johnbowen42 Mar 5, 2025
7b7a617
Merge branch 'develop' into feature/bowen/add-valop-kernel
rhornung67 Apr 1, 2025
26ad3fd
Add openmp kernel reduction implementation
johnbowen42 Apr 3, 2025
8e3dddf
Merge branch 'feature/bowen/add-valop-kernel' of github.com:LLNL/RAJA…
johnbowen42 Apr 3, 2025
7a0c10b
tmp
johnbowen42 Apr 4, 2025
4f37983
fix compile issues and simplify openmp impl
johnbowen42 Apr 7, 2025
cabd5ca
re-enable openmp collapse kernel reduction test
johnbowen42 Apr 8, 2025
ddbfb1a
fix windows build problems
johnbowen42 Apr 8, 2025
0164dee
remove unnecessary file
johnbowen42 Apr 8, 2025
2b85f1d
Fix unit tests
johnbowen42 Apr 17, 2025
814ed68
Supress unused variable warnings
johnbowen42 Apr 23, 2025
6c63efb
Add multi-lambda arg selection test
johnbowen42 Apr 23, 2025
0f251b7
revert cuda kernel
johnbowen42 Apr 23, 2025
ef0fda6
Fix test compilation errors
johnbowen42 Apr 23, 2025
0b7d83f
Unpop tests
johnbowen42 Apr 24, 2025
d0664ce
Suppress warning and fix tests
johnbowen42 Apr 24, 2025
595c2ca
Simplify CUDA/HIP param reduction implementations
johnbowen42 May 2, 2025
3b30a8b
Move filter reducers implementation to camp. Simplify openmp forall i…
johnbowen42 May 15, 2025
6aa6ac0
Merge branch 'develop' into feature/bowen/add-valop-kernel
johnbowen42 May 15, 2025
17ea0f6
add submodule
johnbowen42 May 15, 2025
b4a9a73
Bump camp submodule sha
johnbowen42 May 16, 2025
be3c8f0
Merge branch 'develop' into feature/bowen/add-valop-kernel
johnbowen42 May 16, 2025
ec93b1b
Respond to review feedback
johnbowen42 May 20, 2025
920f46d
fix constructor ambiguity
johnbowen42 May 20, 2025
b280388
fix constructor issue
johnbowen42 May 20, 2025
473757e
Tweak unit test and add overload
johnbowen42 May 22, 2025
63007d8
Merge branch 'develop' into feature/bowen/add-valop-kernel
johnbowen42 May 22, 2025
154bd6d
make case consistent
johnbowen42 May 22, 2025
fa860cd
Respond to feedback
johnbowen42 May 23, 2025
e53d650
Fix Index2D loc initalizer
johnbowen42 May 23, 2025
70d2ea9
add global kernel test
johnbowen42 May 23, 2025
af8a5ff
Merge branch 'feature/bowen/add-valop-kernel' of github.com:LLNL/RAJA…
johnbowen42 May 23, 2025
9544a70
add init call to kernel pattern and simplify params in test
johnbowen42 May 27, 2025
3678e55
Move type traits into unified header file. Add wrapper type traits
johnbowen42 May 30, 2025
969bdb0
Merge branch 'develop' into feature/bowen/add-valop-kernel
johnbowen42 May 30, 2025
29f8346
Fix typo
johnbowen42 May 30, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions examples/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,10 @@ raja_add_executable(
NAME kernel-dynamic-tile
SOURCES kernel-dynamic-tile.cpp)

raja_add_executable(
NAME kernel-reduction
SOURCES kernel-reduction.cpp)

raja_add_executable(
NAME resource-kernel
SOURCES resource-kernel.cpp)
Expand Down
2 changes: 1 addition & 1 deletion examples/forall-param-reductions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
#include "RAJA/RAJA.hpp"

/*
* Reduction Example
* Forall Param Reduction Example
*
* This example illustrates use of the RAJA reduction types: min, max,
* sum, min-loc, and max-loc.
Expand Down
Loading