Adding Swedish entries in various json #2715

Polypheides · 2025-03-21T12:02:26Z

Adding various entries for the Swedish language in the .json located in /Patch104pZH/

This will not build with current gametextcompiler.

xezon

Looks good to me in principle.

Perhaps you can also create the same change for Ukrainian afterwards (in a separate change)?

xezon · 2025-03-21T12:17:14Z

Patch104pZH/ModBundleCoreLanguageItems.json

+                        "sourceList": [
+                            "Data/Swedish/*.ini"
+                        ],
+                        "registryList": [


This can be removed here.

Lets see if i understand this, should i not add anything to this file or is it these specific lines i don't need here?

if removing line 407-410 how should it look to make sure its correct?
Example 1:

or should i use other added languages as template like Arabic if so the Swedish entry would look similar to the Arabic one like this
Example 2:

What I mean is you can remove the

"registryList": [ "Resources/FileHashRegistry/Generals-108-GeneralsZH-104.csv" ]

When using what i have in the commit it will build but removing the lines you suggested the json decoder gives me errors.

So maybe using the Arabic snippet example 2 is better with a source and target? when tested this build as well.

You need to remove the comma above as well.

After removing the comma FullSwedish

I guess we don't want the translation to use the English folder for any added language in the long run, but i noticed that Russian and Arabic uses "setGameLanguageOnInstall": "English", and "sourceTargetList"

While other language uses "sourceList":

So maybe my entry is all wrong and should be like Arabic and Russian.

That is because the community made Russian and Arabic (and Swedish, Ukrainian) are not yet standalone languages. They rely on English big files to provide the base audio, that the Patch replaces in part. As long as that is the case, the community made languages use "English".

Perhaps we should document that somewhere. We cannot put comments in Json.

would this work in a way?

"name": "CoreLangArabic", "_comment": "This Arabic localization is community-made", "big": true, "setGameLanguageOnInstall": "English", "files":

Yes that would work.

xezon · 2025-03-21T12:23:02Z

Patch104pZH/ModBundleCoreLanguageItems.json

+                            }
+                        ],
+                        "params": {
+                            "language": "Swedish",


Will this cause an error on build?

it depends on where or how an error would occur, i ran the BuildInstallRunWithGui.bat without issues.

Select the Swedish pack in the gui and click on Build.

it will build and launch the game with core or full Swedish, but i do have a modified gametextcompiler.exe for Swedish if that is needed for the build process.

Is there a build log text output i can link or just the command line?

for the gametextcompiler

xezon/Thyme@88b7c40

Does it work with old gametextcompiler that does not have Swedish added yet?

Does it work with old gametextcompiler that does not have Swedish added yet?

Short answer: No

Long answer:
I have made a pull request over at xezon/thyme this will implement Swedish and many other languages.

We would need to add this new version over at https://github.com/TheSuperHackers/GeneralsTools/tree/main/Tools
so this will be fetched when running the setup

Here is a link for a compiled gametextcompiler.exe https://www.dropbox.com/scl/fi/4jsp12fdb2tzh1y4d1wi1/gametextcompiler.zip?rlkey=dfnlkc5rja8wem32abosoh4rs&st=dt0qyodw&dl=0

Ok. If Swedish breaks build right now then we need to postpone submit until after new gametextcompiler is hooked up.

Ok. If Swedish breaks build right now then we need to postpone submit until after new gametextcompiler is hooked up.

Building Swedish and Ukrainian fail, building all the other languages succeed.

Do Post Build ... Build Job completed in 21.192 s

We need to update the WindowsTools.json with size hash and github link.

The error when building Swedish with the current main branch build progress and compiler:
subprocess.CalledProcessError: Command '['C:\\Users\\Film\\Desktop\\GENERALS\\PATCH1~1\\Scripts\\Windows\\.tools\\gametextcompiler.exe', '-LOAD_STR', 'C:\\Users\\Film\\Desktop\\GENERALS\\PATCH1~1\\.Build\\RawBundleItems\\CoreLangSwedish\\Data\\Swedish\\generals.csf.tmp', '-SAVE_CSF', 'C:\\Users\\Film\\Desktop\\GENERALS\\PATCH1~1\\.Build\\RawBundleItems\\CoreLangSwedish\\Data\\Swedish\\generals.csf', '-LOAD_STR_LANGUAGES', 'Swedish']' returned non-zero exit status 2.

My additions should fix all this when the compiler gets added to the tool repo.

Polypheides · 2025-03-21T13:49:23Z

Looks good to me in principle.

Perhaps you can also create the same change for Ukrainian afterwards (in a separate change)?

Sure when as soon as we figure out what is needed or not since I'm not a coder i heavily rely on random testing, asking questions and GPT misinformation.

xezon

Looks

xezon · 2025-03-30T09:59:25Z

Patch104pZH/ModBundleCoreLanguageItems.json

+                            }
+                        ],
+                        "params": {
+                            "language": "Swedish",


Does it work with old gametextcompiler that does not have Swedish added yet?

xezon · 2025-03-30T10:07:21Z

Patch104pZH/ModBundleCoreLanguageItems.json

+            },
+            {
+                "name": "CoreLangSwedish",
+                "_comment": "This Swedish localization is community-made",


I think this comment is not necessary here. There already is a wiki page somewhere which could list the original game languages, which then implies which ones are community made.

Here is the wiki page
https://github.com/TheSuperHackers/GeneralsGamePatch/wiki/localization_contribution

Removed

Reason i added the comment in the file was for future people so they could know by just browsing the JSON about what language were community-based!

The other JSON PR #2717 i made has all the comments in all the files but i guess i should remove them there as well.

xezon reviewed Mar 21, 2025

View reviewed changes

DevGeniusCode mentioned this pull request Mar 25, 2025

Fix yaml XP rewards for China Hacker #2695

Open

Polypheides mentioned this pull request Mar 25, 2025

Fix Adding missing Arabic and Ukrainian in various JSON #2717

Draft

xezon reviewed Mar 30, 2025

View reviewed changes

Polypheides requested a review from xezon March 30, 2025 13:58

Polypheides force-pushed the Adding-SE-entries-in-json branch from 053bc61 to 6701c8b Compare June 10, 2025 08:25

Polypheides closed this Jun 11, 2025

Polypheides deleted the Adding-SE-entries-in-json branch June 11, 2025 19:32

Polypheides restored the Adding-SE-entries-in-json branch June 11, 2025 19:33

Polypheides reopened this Jun 11, 2025

Add Swedish localization entries in JSON files

8f09413

Polypheides force-pushed the Adding-SE-entries-in-json branch from 6701c8b to 8f09413 Compare June 11, 2025 20:23

Adding Swedish entries in various json #2715

Are you sure you want to change the base?

Adding Swedish entries in various json #2715

Uh oh!

Conversation

Polypheides commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xezon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Polypheides Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Polypheides Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Polypheides Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Polypheides Mar 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Polypheides commented Mar 21, 2025

Uh oh!

xezon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Polypheides Mar 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Polypheides commented Mar 21, 2025 •

edited

Loading

Polypheides Mar 21, 2025 •

edited

Loading

Polypheides Mar 21, 2025 •

edited

Loading

Polypheides Mar 21, 2025 •

edited

Loading

Polypheides Mar 30, 2025 •

edited

Loading

Polypheides Mar 30, 2025 •

edited

Loading