Skip to content

Solve garbage collector issue #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 15, 2025
Merged

Conversation

nesitor
Copy link
Member

@nesitor nesitor commented May 12, 2025

Solved the issue where some files accumulated on IPFS are not deleted by the Garbage Collector.

Self proofreading checklist

  • Is my code clear enough and well documented
  • Are my files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • Database migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Changes

  • Change the way of checking if a file is pinned or not with a left join instead of an exists.
  • Updated kubo version from 0.15.0 to 0.34.1.
  • Remove manual Garbage collection call at the end and enable the GC on the daemon.
  • Improved json error logging.

How to test

Send a store message without balance and check that the message is rejected. After 24 hours, the file should be already deleted from IPFS storage and files table.

@nesitor nesitor requested review from aliel and amalcaraz May 12, 2025 19:29
@nesitor nesitor self-assigned this May 12, 2025
@nesitor nesitor force-pushed the andres-fix-solve_garbage_collector_issue branch from 4e4547d to bf7e7cf Compare May 14, 2025 14:43
@nesitor nesitor force-pushed the andres-fix-solve_garbage_collector_issue branch from bf7e7cf to e30fd0f Compare May 15, 2025 08:38
@nesitor nesitor merged commit ad19c70 into main May 15, 2025
5 checks passed
@nesitor nesitor deleted the andres-fix-solve_garbage_collector_issue branch May 15, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants