project/ad4062: Resolve critical warnings #1882
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ports have been previously renamed to match the I2C variant. Signed-off-by: Jorge Marques <[email protected]>
To solve 'Reset pin is connected to asynchronous reset source', may not solve asynchronous use case, currently unused. Signed-off-by: Jorge Marques <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The first was an oversight on the rename to match the common project, due to the overlay effort.
The second is due to vivado not inferring the clock that the reset is synchronous to, in this case, set it explicitly associate for the synchronous case.
PR Type
PR Checklist