Various performance optimizations #262
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @DanBmh |
|
At least with my setup (ubuntu22+docker), the camera reconnection on the humble branch does not work if i plug out and in the USB cable: |
|
I have retested the two branches (this and humble) again today, and interestingly the delay benefit was much lower this time. Maybe you could test the delay difference with one of your cameras? I've measured delay with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced the image grabbing/processing time by about 30% for my a2A1920-160umBAS.
Instead of 18ms per frame it now only takes 12ms per frame.
Influence of changes:
The main reason for the time improvements is that the api calls in those code snippets take a lot of time.
There should be further optimization options in other methods as well. Basically the best option might be a complete reimplementation of the parameter handling which stores/updates them as class attributes each time they are changed, so that they don't need to be requested every time.