Skip to content

[repo] Bump rust version and dependencies #2532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 31, 2025
Merged

[repo] Bump rust version and dependencies #2532

merged 5 commits into from
Jul 31, 2025

Conversation

EclecticGriffin
Copy link
Collaborator

I've bumped the rust version to 1.88 and also updated the versions of our rust dependencies. As this updates clippy, that means a bunch of new lints are active now, so I had to go and correct those as well. The vast majority are format string related.

Unfortunately that makes for a bit of a big PR.

@EclecticGriffin EclecticGriffin requested review from sampsyo and ekiwi July 29, 2025 18:31
Copy link
Contributor

@ekiwi ekiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I scanned through it, and it looks good. Basically mostly a number of format string changes.

@EclecticGriffin
Copy link
Collaborator Author

Incidentally there is still a future incompatibility warning because morty hasn't been updated in several years and uses and old version of sv-parser which uses a version of nom that triggers the warning. Naturally there are later versions of sv-parser that don't do this but morty isn't using them. For now it's probably not an issue, but as the crate seems largely unmaintained at this point it may be necessary to take some action once it becomes a hard error.

Copy link
Contributor

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, @EclecticGriffin! The string-templating changes, while sensible, are a bit of a slog. I'll go ahead and merge this now!

About the morty: unfortunately, this is such a useful dependency that it would be a shame to just try to remove it... maybe we should look to see if it is feasible to contribute a version bump?

@sampsyo sampsyo merged commit d617448 into main Jul 31, 2025
18 checks passed
@sampsyo sampsyo deleted the repo/bump-versions branch July 31, 2025 15:43
@sampsyo
Copy link
Contributor

sampsyo commented Jul 31, 2025

I wasted a little bit of time looking into this and ended up opening pulp-platform/morty#65. However, along the way, I noticed that the git trunk for morty already has fresh enough dependencies—so I've opened #2535 to just depend on that instead of the released version.

@EclecticGriffin
Copy link
Collaborator Author

Oh cool! Glad it was easy to resolve. Was worried we'd have to make a fork and bump a ton of dependencies ourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants