Simplify clientHook's refcounting scheme. #496
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no actual reason why we need separate refcounts for calls and clients. In preparation for generally unifying the refcounting in this library, I've decided we should just merge them.
lthibault
previously approved these changes
Apr 1, 2023
...because fewer special cases are better. This also resolves everything but the documentation for capnproto#423. One of the tests had to be reworked a bit because the exact sequence of messages was a bit different, but still correct.
|
I merged in #502, which fixed the test failures locally, so hopefully it should do so in CI as well. That PR should be reviewed & merged first. |
|
#348, re-running. |
This can't possibly have any effect, since we close the same channel immediately above. The close used to be conditional, so it presumably made more sense then.
lthibault
approved these changes
Apr 13, 2023
|
Per my long rambly rubber-ducking session on matrix, there is a reason for having two separate refcounts: if refs hits zero Client.Release() will block on calls hitting zero before returning. This patch breaks that, oops. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no actual reason why we need separate refcounts for calls and clients. In preparation for generally unifying the refcounting in this library, I've decided we should just merge them.