Get rid of the bootstrapClient implementation of ClientHook. #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
...and I tacked on one more commit fixing the docs for ClientHook.Shutdown(). |
zenhack
force-pushed
the
kill-bootstrapClient
branch
from
ad1a941 to
ad4f48e
Compare
...because fewer special cases are better. This also resolves everything but the documentation for capnproto#423. One of the tests had to be reworked a bit because the exact sequence of messages was a bit different, but still correct.
|
Note that this PR also fixes the CI errors in #496, at least on my local machine. |
lthibault
requested changes
Apr 12, 2023
Per Louis's questions.
lthibault
approved these changes
Apr 12, 2023
|
#348 again, re-running. I'm hopeful that doing all of the refcount refactoring I have in mind will root that one out, though not sure how many of those need to be on the stack of yaks I've been shaving for 3ph... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...because fewer special cases are better. This also resolves everything but the documentation for #423.
One of the tests had to be reworked a bit because the exact sequence of messages was a bit different, but still correct.