Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Cast for JSON #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Cast for JSON #265
Changes from 5 commits
dbc6393
b3fe074
5fe33e4
f671a3d
be6792c
bd72498
c487dd0
b6ddc9b
ec6efc8
a8de8cf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Verification inconclusive
Missing import for SpannerJsonType class.
The
SpannerJsonType
class is used but not imported. This will cause a runtime error.+use Colopl\Spanner\Query\Grammar\SpannerJsonType; namespace Colopl\Spanner\Casts;
Please verify the correct namespace and path for the
SpannerJsonType
class in your codebase.🏁 Script executed:
Length of output: 129
Verify Missing Import for SpannerJsonType
The code instantiates a new
SpannerJsonType($value)
on line 36 ofsrc/Casts/SpannerJson.php
without an import. We attempted to verify its existence using a search for a class declaration but did not find a matching definition. Please manually verify whether theSpannerJsonType
class exists in the codebase:use Colopl\Spanner\Query\Grammar\SpannerJsonType;
is unconfirmed).