Skip to content

Update localizations for Spanish and Traditional Chinese #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025

Conversation

stonkol
Copy link
Contributor

@stonkol stonkol commented May 28, 2025

Now the Spanish and Traditional Chinese locations are up to date.

@stonkol stonkol requested a review from 1024jp as a code owner May 28, 2025 02:02
Copy link
Member

@1024jp 1024jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request.
I’ve reviewed your changes.
Please check my inline comments and respond to them.

@1024jp
Copy link
Member

1024jp commented May 30, 2025

In addition, it appears that some files still need to be reviewed.

  • files in Localizables > Settings > Panes
  • Storyboards > Main
  • Storyboards > SyntaxListView
    The localizable files for storyboards can be accessed by opening the left disclosure of each storyboard in Xcode.

@1024jp 1024jp self-assigned this May 30, 2025
@1024jp 1024jp added the localization tasks related to application localization label May 30, 2025
@1024jp 1024jp added this to the 5.1.7 milestone May 30, 2025
@stonkol
Copy link
Contributor Author

stonkol commented Jun 1, 2025

Ok, I will prepare a new version with the changes

@stonkol
Copy link
Contributor Author

stonkol commented Jun 2, 2025

I added a new commit now, with the changes.

@1024jp 1024jp merged commit 7dcf0bd into coteditor:main Jun 2, 2025
1 check passed
@1024jp
Copy link
Member

1024jp commented Jun 2, 2025

Thank you for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization tasks related to application localization
Development

Successfully merging this pull request may close these issues.

2 participants