-
Notifications
You must be signed in to change notification settings - Fork 562
Improvement/add more linters #2045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Saurabh2402
wants to merge
34
commits into
diggerhq:develop
Choose a base branch
from
Saurabh2402:improvement/add-more-linters
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Improvement/add more linters #2045
Saurabh2402
wants to merge
34
commits into
diggerhq:develop
from
Saurabh2402:improvement/add-more-linters
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…improvement/formatting-setup
…-> scmRepository]
- mirror - unconvert - usestdlibvars - misspell
…ariable) 2. usestdlibvars: use http.Method instead of "GET" and similar changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Add More Linting Rules and Apply Code Quality Fixes:
Changes Made
🛠️ New Linters Added
govet
: Enhanced Go vet analysis for detecting suspicious constructsgocritic
: Advanced static analysis with performance and style checkswhitespace
: Enforces consistent whitespace usagemirror
: Detects wrong mirror usage of bytes/strings usageunconvert
: Removes unnecessary type conversionsusestdlibvars
: Suggests using standard library constants instead of hardcoded valuesmisspell
: Catches common spelling mistakes (configured for UK locale)tagalign
: Ensures consistent struct tag alignmentthelper
: Validates proper usage of t.Helper() in test functionsPossible bugs found and fixed:
Maintainer's Review Needed: @motatoes
🔄 Branch Synchronization
Synced with base linting setup PR(#2042) to prevent merge conflicts since it would get merged first.