Improvement/add more linters

.golangci.yml

@@ -0,0 +1,40 @@
+# See for configurations: https://golangci-lint.run/usage/configuration/
+version: 2
+# See: https://golangci-lint.run/usage/formatters/
+formatters:
+  default: none
+  enable:
+    - gofmt # https://pkg.go.dev/cmd/gofmt
+    - gofumpt # https://github.com/mvdan/gofumpt
+    - goimports # https://pkg.go.dev/golang.org/x/tools/cmd/goimports
+
+  settings:
+    gofmt:
+      simplify: true # Simplify code: gofmt with `-s` option.
+
+    gofumpt:
+      # Module path which contains the source code being formatted.
+      # Default: ""
+      module-path: github.com/diggerhq/digger # Should match with module in go.mod
+      # Choose whether to use the extra rules.
+      # Default: false
+      extra-rules: true
+
+# See: https://golangci-lint.run/usage/linters/
+linters:
+  default: none
+  enable:
+    - staticcheck
+    - govet
+    - gocritic
+    - whitespace
+    - mirror
+    - unconvert
+    - usestdlibvars
+    - misspell
+    - tagalign
+    - thelper
+
+settings:
+  misspell:
+    locale: UK

backend/bootstrap/main.go

@@ -11,15 +11,14 @@ import (
 	"path/filepath"
 	"runtime"
 	"runtime/pprof"
+	"time"
 
 	"github.com/diggerhq/digger/backend/config"
 	"github.com/diggerhq/digger/backend/segment"
 	"github.com/diggerhq/digger/backend/utils"
 	pprof_gin "github.com/gin-contrib/pprof"
 	sloggin "github.com/samber/slog-gin"
 
-	"time"
-
 	"github.com/diggerhq/digger/backend/controllers"
 	"github.com/diggerhq/digger/backend/middleware"
 	"github.com/diggerhq/digger/backend/models"
@@ -38,7 +37,7 @@ func setupProfiler(r *gin.Engine) {
 	pprof_gin.Register(r)
 
 	// Create profiles directory if it doesn't exist
-	if err := os.MkdirAll("/tmp/profiles", 0755); err != nil {
+	if err := os.MkdirAll("/tmp/profiles", 0o755); err != nil {
 		slog.Error("Failed to create profiles directory", "error", err)
 		panic(err)
 	}
@@ -115,7 +114,7 @@ func Bootstrap(templates embed.FS, diggerController controllers.DiggerController
 		slog.Error("Sentry initialization failed", "error", err)
 	}
 
-	//database migrations
+	// database migrations
 	models.ConnectDatabase()
 
 	r := gin.Default()
@@ -262,13 +261,14 @@ func initLogging() {
 	logLevel := os.Getenv("DIGGER_LOG_LEVEL")
 	var level slog.Leveler
 
-	if logLevel == "DEBUG" {
+	switch logLevel {
+	case "DEBUG":
 		level = slog.LevelDebug
-	} else if logLevel == "WARN" {
+	case "WARN":
 		level = slog.LevelWarn
-	} else if logLevel == "ERROR" {
+	case "ERROR":
 		level = slog.LevelError
-	} else {
+	default:
 		level = slog.LevelInfo
 	}
 

backend/ci_backends/ci_backends.go

@@ -6,7 +6,7 @@ import (
 )
 
 type CiBackend interface {
-	TriggerWorkflow(spec spec.Spec, runName string, vcsToken string) error
+	TriggerWorkflow(spec spec.Spec, runName, vcsToken string) error
 	GetWorkflowUrl(spec spec.Spec) (string, error)
 }
 

backend/ci_backends/github_actions.go

@@ -16,7 +16,7 @@ type GithubActionCi struct {
 	Client *github.Client
 }
 
-func (g GithubActionCi) TriggerWorkflow(spec spec.Spec, runName string, vcsToken string) error {
+func (g GithubActionCi) TriggerWorkflow(spec spec.Spec, runName, vcsToken string) error {
 	slog.Info("TriggerGithubWorkflow", "repoOwner", spec.VCS.RepoOwner, "repoName", spec.VCS.RepoName, "commentId", spec.CommentId)
 	client := g.Client
 	specBytes, err := json.Marshal(spec)

backend/config/config.go

@@ -1,11 +1,12 @@
 package config
 
 import (
-	"github.com/spf13/cast"
 	"os"
 	"strings"
 	"time"
 
+	"github.com/spf13/cast"
+
 	"github.com/spf13/viper"
 )
 

backend/controllers/activity.go

@@ -3,11 +3,12 @@ package controllers
 import (
 	"errors"
 	"fmt"
+	"net/http"
+
 	"github.com/diggerhq/digger/backend/middleware"
 	"github.com/diggerhq/digger/backend/models"
 	"github.com/gin-gonic/gin"
 	"gorm.io/gorm"
-	"net/http"
 )
 
 func GetActivity(c *gin.Context) {

backend/controllers/billing.go

@@ -2,12 +2,13 @@ package controllers
 
 import (
 	"errors"
+	"log/slog"
+	"net/http"
+
 	"github.com/diggerhq/digger/backend/middleware"
 	"github.com/diggerhq/digger/backend/models"
 	"github.com/gin-gonic/gin"
 	"gorm.io/gorm"
-	"log/slog"
-	"net/http"
 )
 
 func BillingStatusApi(c *gin.Context) {

backend/controllers/cache.go

@@ -2,13 +2,14 @@ package controllers
 
 import (
 	"fmt"
-	"github.com/diggerhq/digger/libs/git_utils"
 	"log/slog"
 	"net/http"
 	"os"
 	"path"
 	"strings"
 
+	"github.com/diggerhq/digger/libs/git_utils"
+
 	"github.com/diggerhq/digger/backend/models"
 	"github.com/diggerhq/digger/backend/utils"
 	dg_configuration "github.com/diggerhq/digger/libs/digger_config"
@@ -78,7 +79,6 @@ func (d DiggerController) UpdateRepoCache(c *gin.Context) {
 			}
 			return nil
 		})
-
 		if err != nil {
 			slog.Error("Could not load digger config", "error", err)
 			return

backend/controllers/connections.go

@@ -61,7 +61,7 @@ func CreateVCSConnectionApi(c *gin.Context) {
 	}
 
 	type CreateVCSConnectionRequest struct {
-		VCS                    string `json:"type" binding:"required"`
+		VCS                    string `binding:"required"              json:"type"`
 		Name                   string `json:"connection_name"`
 		BitbucketAccessToken   string `json:"bitbucket_access_token"`
 		BitbucketWebhookSecret string `json:"bitbucket_webhook_secret"`
@@ -123,7 +123,6 @@ func CreateVCSConnectionApi(c *gin.Context) {
 		slog.Error("Could not create VCS connection", "error", err)
 		c.JSON(http.StatusInternalServerError, gin.H{"error": "Could not create VCS connection"})
 		return
-
 	}
 
 	slog.Info("Created VCS connection", "connectionId", connection.ID, "organisationId", org.ID)