Fix default logLevel testingConfig #2617
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
| @@ -252,8 +252,6 @@ internal MutableSnapshot(IRawConfigSnapshot rawConfigSnapshot, ITestOutputHelper | |||
|
|
|||
| optionMetadata.ParseAndSetProperty(rawConfigSnapshot, this, parsingLogger); | |||
| } | |||
| if (IsRunningInIde) | |||
| LogLevel = LogLevel.Trace; | |||
There was a problem hiding this comment.
I'm wondering if the IsRunningInIde` check is the root cause? I think the intention of this code is to apply when debugging locally, so it shouldn't affect CI failures.
There was a problem hiding this comment.
yes
The test step is working in CI but doesn't work locally, the unit-tests are not working locally.
When running the unit-tests locally, this piece of code change the default log level locally, set it to trace but the test verifies that it should be Error and fails.
This file is only used in the unit-tests and not anywhere else
The failing tests in CI are the 'azure-tests' and should be tackled separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.