Skip to content

Fix default logLevel testingConfig #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix default logLevel testingConfig #2617

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bb71aad
Fix default logLevel testingConfig
JeremyBessonElastic Jun 25, 2025
e268098
Testing if terraform is installed
JeremyBessonElastic Jun 26, 2025
b4c2153
Try to install terraform for Azure tests
JeremyBessonElastic Jun 26, 2025
0e9a0f7
Revert terraform changes
JeremyBessonElastic Jun 27, 2025
172e6ab
Fix
JeremyBessonElastic Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions test/Elastic.Apm.Tests.Utilities/TestingConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,6 @@ internal MutableSnapshot(IRawConfigSnapshot rawConfigSnapshot, ITestOutputHelper

optionMetadata.ParseAndSetProperty(rawConfigSnapshot, this, parsingLogger);
}
if (IsRunningInIde)
LogLevel = LogLevel.Trace;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if the IsRunningInIde` check is the root cause? I think the intention of this code is to apply when debugging locally, so it shouldn't affect CI failures.

Copy link
Collaborator Author

@JeremyBessonElastic JeremyBessonElastic Jun 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

The test step is working in CI but doesn't work locally, the unit-tests are not working locally.
When running the unit-tests locally, this piece of code change the default log level locally, set it to trace but the test verifies that it should be Error and fails.
This file is only used in the unit-tests and not anywhere else

The failing tests in CI are the 'azure-tests' and should be tackled separately


IApmLogger BuildXunitOutputLogger(LogLevel logLevel)
{
Expand Down
Loading