Skip to content

disable ReplaceStringCasingWithInsensitiveRegexMatch rule in 8.19 #131387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 17, 2025

Conversation

julian-elastic
Copy link
Contributor

@julian-elastic julian-elastic commented Jul 16, 2025

This PR disables the ReplaceStringCasingWithInsensitiveRegexMatch rule for 8.19, originally added with #128919
This is due to Lucene missing support for Unicode CASE_INSENSITIVE automation. If we allow the pushdown, we end up with wrong data in the vase majority of the cases when Unicode characters are involved.
#131386 is logged for a complete fix and to reenable the change

@julian-elastic julian-elastic marked this pull request as ready for review July 16, 2025 19:08
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v8.19.1 labels Jul 16, 2025
@julian-elastic julian-elastic added >bug :Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Jul 16, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Jul 16, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @julian-elastic, I've created a changelog YAML for you.

@julian-elastic julian-elastic force-pushed the disableCaseInsensitive branch from 8ab7107 to ee65f6d Compare July 16, 2025 20:58
Copy link
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@julian-elastic julian-elastic self-assigned this Jul 17, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @julian-elastic, I've created a changelog YAML for you.

@julian-elastic julian-elastic merged commit 3a2862d into elastic:8.19 Jul 17, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants