Skip to content

disable ReplaceStringCasingWithInsensitiveRegexMatch rule in 8.19 #131387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 17, 2025
Merged

disable ReplaceStringCasingWithInsensitiveRegexMatch rule in 8.19 #131387

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ee65f6d
disable ReplaceStringCasingWithInsensitiveRegexMatch rule in 8.19
julian-elastic Jul 16, 2025
e02754d
disable ReplaceStringCasingWithInsensitiveRegexMatch rule in 8.19
julian-elastic Jul 16, 2025
7f388b1
Fix UTs
julian-elastic Jul 17, 2025
2584aa4
Merge remote-tracking branch 'upstream/8.19' into disableCaseInsensitive
julian-elastic Jul 17, 2025
8608bfb
Address code review comments
julian-elastic Jul 17, 2025
f5ff516
Update docs/changelog/131387.yaml
julian-elastic Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 34 additions & 1 deletion muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,4 +411,37 @@ tests:
issue: https://github.com/elastic/elasticsearch/issues/126085
- class: org.elasticsearch.smoketest.DocsClientYamlTestSuiteIT
method: test {yaml=reference/search/retriever/line_906}
issue: https://github.com/elastic/elasticsearch/issues/131041
issue: https://github.com/elastic/elasticsearch/issues/131041
- class: org.elasticsearch.xpack.esql.optimizer.PhysicalPlanOptimizerTests
method: testPushDownUpperCaseChangeRLike
issue: https://github.com/elastic/elasticsearch/issues/131386
- class: org.elasticsearch.xpack.esql.optimizer.PhysicalPlanOptimizerTests
method: testChangeCaseAsInsensitiveWildcardLikeNotPushedDown
issue: https://github.com/elastic/elasticsearch/issues/131386
- class: org.elasticsearch.xpack.esql.optimizer.PhysicalPlanOptimizerTests
method: testPushDownUpperCaseChangeLike
issue: https://github.com/elastic/elasticsearch/issues/131386
- class: org.elasticsearch.xpack.esql.optimizer.PhysicalPlanOptimizerTests
method: testPushDownLowerCaseChangeRLike
issue: https://github.com/elastic/elasticsearch/issues/131386
- class: org.elasticsearch.xpack.esql.optimizer.PhysicalPlanOptimizerTests
method: testPushDownLowerCaseChangeLike
issue: https://github.com/elastic/elasticsearch/issues/131386
- class: org.elasticsearch.xpack.esql.optimizer.LocalLogicalPlanOptimizerTests
method: testReplaceUpperStringCasinqgWithInsensitiveRLike
issue: https://github.com/elastic/elasticsearch/issues/131386
- class: org.elasticsearch.xpack.esql.optimizer.LocalLogicalPlanOptimizerTests
method: testReplaceLowerStringCasingWithInsensitiveRLike
issue: https://github.com/elastic/elasticsearch/issues/131386
- class: org.elasticsearch.xpack.esql.optimizer.LocalLogicalPlanOptimizerTests
method: testReplaceLowerStringCasingWithInsensitiveLike
issue: https://github.com/elastic/elasticsearch/issues/131386
- class: org.elasticsearch.xpack.esql.optimizer.LocalLogicalPlanOptimizerTests
method: testReplaceUpperStringCasingWithInsensitiveLike
issue: https://github.com/elastic/elasticsearch/issues/131386
- class: org.elasticsearch.xpack.esql.optimizer.LocalLogicalPlanOptimizerTests
method: testReplaceStringCasingAndLikeWithLocalRelation
issue: https://github.com/elastic/elasticsearch/issues/131386
- class: org.elasticsearch.xpack.esql.optimizer.LocalLogicalPlanOptimizerTests
method: testReplaceStringCasingAndRLikeWithLocalRelation
issue: https://github.com/elastic/elasticsearch/issues/131386
13 changes: 13 additions & 0 deletions x-pack/plugin/esql/qa/testFixtures/src/main/resources/where-like.csv-spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,3 +874,16 @@ emp_no:integer |first_name:keyword
10001 |Georgi
10055 |Georgy
;

rlikeWithLowerTurnedInsensitiveUnicode#[skip:-8.12.99]
FROM airport_city_boundaries
| WHERE TO_UPPER(region) RLIKE ".*Л.*" and abbrev == "FRU"
| KEEP region
| LIMIT 1
;

region:text
Свердлов району
;


5 changes: 3 additions & 2 deletions .../esql/src/main/java/org/elasticsearch/xpack/esql/optimizer/LocalLogicalPlanOptimizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

import org.elasticsearch.xpack.esql.optimizer.rules.logical.PropagateEmptyRelation;
import org.elasticsearch.xpack.esql.optimizer.rules.logical.ReplaceStatsFilteredAggWithEval;
import org.elasticsearch.xpack.esql.optimizer.rules.logical.ReplaceStringCasingWithInsensitiveRegexMatch;
import org.elasticsearch.xpack.esql.optimizer.rules.logical.local.InferIsNotNull;
import org.elasticsearch.xpack.esql.optimizer.rules.logical.local.InferNonNullAggConstraint;
import org.elasticsearch.xpack.esql.optimizer.rules.logical.local.LocalPropagateEmptyRelation;
Expand Down Expand Up @@ -75,7 +74,9 @@ private static Batch<LogicalPlan> localOperators() {
}

// add rule that should only apply locally
newRules.add(new ReplaceStringCasingWithInsensitiveRegexMatch());
// Disabled until Unicode CASE_INSENSITIVE support is added to Lucine 9.0
// waiting on https://github.com/elastic/elasticsearch/issues/131386
// newRules.add(new ReplaceStringCasingWithInsensitiveRegexMatch());

return operators.with(newRules.toArray(Rule[]::new));
}
Expand Down