Skip to content

Remove clean and no-daemon #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Remove clean and no-daemon #903

merged 1 commit into from
Jun 5, 2025

Conversation

runningcode
Copy link
Contributor

📜 Description

We start from a clean slate on CI so running clean only adds time to the
jobs.
Also it is always recommended to use the daemon especially when running
multiple jobs in order to speed up the build.

#skip-changelog

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

We start from a clean slate on CI so running clean only adds time to the
jobs.
Also it is always recommended to use the daemon especially when running
multiple jobs in order to speed up the build.
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall daemon used to cause problems in CI 7-ish years ago but that's probably long gone into the void :D

@runningcode runningcode merged commit 5a90913 into main Jun 5, 2025
19 checks passed
@runningcode runningcode deleted the no/remove-clean branch June 5, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants