Remove some buildscript blocks #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runningcode
requested review from
markushi,
romtsn,
adinauer,
stefanosiano,
lcian,
chromy and
rbro112
as code owners
rbro112
approved these changes
Jun 5, 2025
romtsn
reviewed
Jun 6, 2025
| @@ -1,18 +1,8 @@ | |||
| buildscript { | |||
There was a problem hiding this comment.
i think this was here intentional to test the plugin works with the deprecated buildscript setup. But I guess it's not that relevant anymore so we should be good
There was a problem hiding this comment.
Oh, I can’t foresee a scenario where the new plugin setup would work but this would not work, but happy to add it back if you think it is needed or that happened in the past.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
#skip-changelog
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps