Skip to content

Remove some buildscript blocks #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Remove some buildscript blocks #905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/android-gradle-kts/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
plugins {
alias(libs.plugins.androidApplication) version BuildPluginsVersion.AGP
id("com.android.application")
id("io.sentry.android.gradle")
}

Expand Down
16 changes: 3 additions & 13 deletions examples/android-gradle/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,8 @@
buildscript {
repositories {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this was here intentional to test the plugin works with the deprecated buildscript setup. But I guess it's not that relevant anymore so we should be good

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I can’t foresee a scenario where the new plugin setup would work but this would not work, but happy to add it back if you think it is needed or that happened in the past.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope it's all good 👍

google()
mavenCentral()
}

dependencies {
classpath Libs.AGP
classpath "io.sentry:sentry-android-gradle-plugin"
}
plugins {
id("com.android.application")
id("io.sentry.android.gradle")
}

apply plugin: 'com.android.application'
apply plugin: 'io.sentry.android.gradle'

android {
compileSdk = LibsVersion.SDK_VERSION
defaultConfig {
Expand Down
17 changes: 3 additions & 14 deletions examples/android-ndk/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,8 @@
buildscript {
repositories {
google()
mavenCentral()
}

dependencies {
classpath Libs.AGP
classpath "io.sentry:sentry-android-gradle-plugin"
}
plugins {
id("com.android.application")
id("io.sentry.android.gradle")
}

apply plugin: 'com.android.application'
apply plugin: 'io.sentry.android.gradle'

android {
compileSdk = LibsVersion.SDK_VERSION
ndkVersion = "24.0.8215888"
Expand All @@ -37,7 +27,6 @@ android {
}

if (System.getenv("AUTO_UPLOAD")) {
apply plugin: 'io.sentry.android.gradle'
sentry {
autoUploadProguardMapping = false
uploadNativeSymbols = true
Expand Down
Loading