Skip to content

fix(process_segments): Handle non-numeric measurement values #94766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

seer-by-sentry[bot]
Copy link
Contributor

@seer-by-sentry seer-by-sentry bot commented Jul 2, 2025

Fixes SENTRY-44CH. The issue was that: Network throughput measurement, originating from a browser SDK, is an empty dictionary, causing convert_span_to_item to fail when accessing its expected 'value' key.

  • Ensures measurement values are dictionaries before accessing the 'value' key.
  • Checks if the 'value' key exists in the measurement dictionary.
  • Attempts to convert the measurement value to a float, skipping if conversion fails.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 208228

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 2, 2025
@trillville trillville added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jul 2, 2025
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...sentry/spans/consumers/process_segments/convert.py 71.42% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #94766    +/-   ##
========================================
  Coverage   87.91%   87.92%            
========================================
  Files       10430    10434     +4     
  Lines      603230   603472   +242     
  Branches    23466    23466            
========================================
+ Hits       530353   530575   +222     
- Misses      72371    72391    +20     
  Partials      506      506            

@getsantry
Copy link
Contributor

getsantry bot commented Jul 23, 2025

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Jul 23, 2025
@getsantry
Copy link
Contributor

getsantry bot commented Aug 15, 2025

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Stale Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant