Skip to content

fix(process_segments): Handle non-numeric measurement values #94766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions src/sentry/spans/consumers/process_segments/convert.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,24 @@ def convert_span_to_item(span: Span) -> TraceItem:
sentry_sdk.capture_exception()

for k, v in (span.get("measurements") or {}).items():
if k is not None and v is not None:
if k == "client_sample_rate":
client_sample_rate = v["value"]
elif k == "server_sample_rate":
server_sample_rate = v["value"]
else:
attributes[k] = AnyValue(double_value=float(v["value"]))
if k is None or not isinstance(v, dict):
continue

value = v.get("value")
if value is None:
continue

try:
numeric_value = float(value)
except (ValueError, TypeError):
continue

if k == "client_sample_rate":
client_sample_rate = numeric_value
elif k == "server_sample_rate":
server_sample_rate = numeric_value
else:
attributes[k] = AnyValue(double_value=numeric_value)

for k, v in (span.get("sentry_tags") or {}).items():
if v is not None:
Expand Down
Loading