Skip to content

feat: add delegation_record to route53 resolver rule #43282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

stefanfreitag
Copy link
Contributor

@stefanfreitag stefanfreitag commented Jul 6, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

No changes to security controls.

Description

With DELEGATE a new rule type for Route53 resolver rules has been introduced. The section References contains links to What`s new article and CloudFormation docs.

  • To be able to use DELEGATE as rule type, we need to make the domain_name argument optional: DELEGATE requires a delegation_record containing the DNS name.
  • UpdateResolverRule does not allow to update the delegation_record, hence we ForceNew on changes to delegation_record.
  • ListResolverRules does not support to filter for delegation_record, hence the filter expression in the data source is not updated.

Relations

Closes #43239

References

Output from Acceptance Testing

make testacc TESTS=TestAccRoute53ResolverRule_delegationRecord  PKG=route53resolver
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/route53resolver/... -v -count 1 -parallel 20 -run='TestAccRoute53ResolverRule_delegationRecord'  -timeout 360m -vet=off
2025/07/13 21:36:36 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/13 21:36:36 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccRoute53ResolverRule_delegationRecord
=== PAUSE TestAccRoute53ResolverRule_delegationRecord
=== CONT  TestAccRoute53ResolverRule_delegationRecord
--- PASS: TestAccRoute53ResolverRule_delegationRecord (280.07s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    280.290s

Data source

make testacc TESTS=TestAccRoute53ResolverRuleDataSource_delegationRecord  PKG=route53resolver
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/route53resolver/... -v -count 1 -parallel 20 -run='TestAccRoute53ResolverRuleDataSource_delegationRecord'  -timeout 360m -vet=off
2025/07/13 21:43:47 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/13 21:43:47 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccRoute53ResolverRuleDataSource_delegationRecord
=== PAUSE TestAccRoute53ResolverRuleDataSource_delegationRecord
=== CONT  TestAccRoute53ResolverRuleDataSource_delegationRecord
--- PASS: TestAccRoute53ResolverRuleDataSource_delegationRecord (248.39s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    248.593s

Copy link
Contributor

github-actions bot commented Jul 6, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53resolver Issues and PRs that pertain to the route53resolver service. size/M Managed by automation to categorize the size of a PR. external-maintainer Contribution from a trusted external contributor. labels Jul 6, 2025
@stefanfreitag stefanfreitag force-pushed the f-aws_route53_resolver_rule-add-delegate-type branch from 88ae3e7 to acd1546 Compare July 8, 2025 19:26
@stefanfreitag stefanfreitag force-pushed the f-aws_route53_resolver_rule-add-delegate-type branch from 1954c1c to 39119ea Compare July 13, 2025 19:52
@github-actions github-actions bot added the size/L Managed by automation to categorize the size of a PR. label Jul 13, 2025
@stefanfreitag stefanfreitag marked this pull request as ready for review July 14, 2025 08:43
@stefanfreitag stefanfreitag requested a review from a team as a code owner July 14, 2025 08:43
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. service/route53resolver Issues and PRs that pertain to the route53resolver service. size/L Managed by automation to categorize the size of a PR. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Support for aws_route53_resolver_rule rule_type DELEGATE
2 participants