Add ARN-based resource identity to `ivs` #43704

jar-b · 2025-08-04T20:37:57Z

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Add resource identity to ARN-based resources in ivs. This includes:

aws_ivs_channel
aws_ivs_playback_key_pair
aws_ivs_recording_configuration

Relations

Relates #42983
Relates #42984

Output from Acceptance Testing

% make testacc PKG=ivs TESTS="TestAccIVSChannel|TestAccIVSRecordingConfiguration|TestAccIVS_serial/PlaybackKeyPair/"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/ivs/... -v -count 1 -parallel 20 -run='TestAccIVSChannel|TestAccIVSRecordingConfiguration|TestAccIVS_serial/PlaybackKeyPair/'  -timeout 360m -vet=off
2025/08/04 16:32:55 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/04 16:32:56 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccIVSChannel_disappears (25.72s)
=== RUN   TestAccIVS_serial/PlaybackKeyPair/update
--- PASS: TestAccIVSChannel_basic (29.70s)
--- PASS: TestAccIVSRecordingConfiguration_disappears_S3Bucket (38.53s)
--- PASS: TestAccIVSChannel_Identity_Basic (45.48s)
--- PASS: TestAccIVSRecordingConfiguration_disappears (45.81s)
--- PASS: TestAccIVSChannel_recordingConfiguration (46.30s)
--- PASS: TestAccIVSChannel_update (46.42s)
--- PASS: TestAccIVSRecordingConfiguration_basic (49.21s)
--- PASS: TestAccIVSChannel_Identity_RegionOverride (52.01s)
--- PASS: TestAccIVSChannel_tags (56.36s)
--- PASS: TestAccIVSRecordingConfiguration_Identity_RegionOverride (56.58s)
--- PASS: TestAccIVSChannel_Identity_ExistingResource (60.47s)
=== RUN   TestAccIVS_serial/PlaybackKeyPair/tags
--- PASS: TestAccIVSRecordingConfiguration_Identity_Basic (61.72s)
--- PASS: TestAccIVSRecordingConfiguration_update (64.36s)
--- PASS: TestAccIVSRecordingConfiguration_Identity_ExistingResource (69.30s)
--- PASS: TestAccIVSRecordingConfiguration_tags (77.87s)
=== RUN   TestAccIVS_serial/PlaybackKeyPair/disappears
=== RUN   TestAccIVS_serial/PlaybackKeyPair/identity
=== RUN   TestAccIVS_serial/PlaybackKeyPair/identity/basic
=== RUN   TestAccIVS_serial/PlaybackKeyPair/identity/ExistingResource
=== RUN   TestAccIVS_serial/PlaybackKeyPair/identity/RegionOverride
--- PASS: TestAccIVS_serial (198.39s)
    --- PASS: TestAccIVS_serial/PlaybackKeyPair (198.39s)
        --- PASS: TestAccIVS_serial/PlaybackKeyPair/basic (29.36s)
        --- PASS: TestAccIVS_serial/PlaybackKeyPair/update (31.69s)
        --- PASS: TestAccIVS_serial/PlaybackKeyPair/tags (35.14s)
        --- PASS: TestAccIVS_serial/PlaybackKeyPair/disappears (12.56s)
        --- PASS: TestAccIVS_serial/PlaybackKeyPair/identity (89.64s)
            --- PASS: TestAccIVS_serial/PlaybackKeyPair/identity/basic (22.38s)
            --- PASS: TestAccIVS_serial/PlaybackKeyPair/identity/ExistingResource (41.32s)
            --- PASS: TestAccIVS_serial/PlaybackKeyPair/identity/RegionOverride (25.94s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ivs        204.684s

github-actions · 2025-08-04T20:38:07Z

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
Please see our prioritization guide for additional information on how the maintainers handle prioritization.
Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

gdavison

One nit: the resource type that we're testing should be the first in the configuration. Otherwise, looks good

internal/service/ivs/testdata/tmpl/recording_configuration_tags.gtpl

jar-b · 2025-08-06T19:02:35Z

After update of the pre identity version.

% make testacc PKG=ivs TESTS="TestAccIVSChannel|TestAccIVSRecordingConfiguration|TestAccIVS_serial/PlaybackKeyPair/"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/ivs/... -v -count 1 -parallel 20 -run='TestAccIVSChannel|TestAccIVSRecordingConfiguration|TestAccIVS_serial/PlaybackKeyPair/'  -timeout 360m -vet=off
2025/08/06 14:57:32 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/06 14:57:32 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccIVSChannel_disappears (30.74s)
--- PASS: TestAccIVSChannel_basic (36.99s)
--- PASS: TestAccIVSRecordingConfiguration_disappears (43.99s)
--- PASS: TestAccIVSRecordingConfiguration_disappears_S3Bucket (44.98s)
=== RUN   TestAccIVS_serial/PlaybackKeyPair/tags
--- PASS: TestAccIVSChannel_recordingConfiguration (52.33s)
--- PASS: TestAccIVSRecordingConfiguration_basic (52.52s)
--- PASS: TestAccIVSChannel_Identity_Basic (55.28s)
--- PASS: TestAccIVSChannel_update (55.33s)
--- PASS: TestAccIVSChannel_Identity_RegionOverride (61.16s)
--- PASS: TestAccIVSRecordingConfiguration_Identity_RegionOverride (63.90s)
--- PASS: TestAccIVSChannel_tags (66.40s)
--- PASS: TestAccIVSRecordingConfiguration_Identity_Basic (69.27s)
--- PASS: TestAccIVSChannel_Identity_ExistingResource (69.83s)
--- PASS: TestAccIVSRecordingConfiguration_update (74.72s)
--- PASS: TestAccIVSRecordingConfiguration_Identity_ExistingResource (74.75s)
--- PASS: TestAccIVSRecordingConfiguration_tags (84.18s)
=== RUN   TestAccIVS_serial/PlaybackKeyPair/disappears
=== RUN   TestAccIVS_serial/PlaybackKeyPair/identity
=== RUN   TestAccIVS_serial/PlaybackKeyPair/identity/ExistingResource
=== RUN   TestAccIVS_serial/PlaybackKeyPair/identity/RegionOverride
=== RUN   TestAccIVS_serial/PlaybackKeyPair/identity/basic
=== RUN   TestAccIVS_serial/PlaybackKeyPair/basic
--- PASS: TestAccIVS_serial (205.39s)
    --- PASS: TestAccIVS_serial/PlaybackKeyPair (205.39s)
        --- PASS: TestAccIVS_serial/PlaybackKeyPair/update (45.14s)
        --- PASS: TestAccIVS_serial/PlaybackKeyPair/tags (43.46s)
        --- PASS: TestAccIVS_serial/PlaybackKeyPair/disappears (12.14s)
        --- PASS: TestAccIVS_serial/PlaybackKeyPair/identity (90.01s)
            --- PASS: TestAccIVS_serial/PlaybackKeyPair/identity/ExistingResource (41.90s)
            --- PASS: TestAccIVS_serial/PlaybackKeyPair/identity/RegionOverride (26.19s)
            --- PASS: TestAccIVS_serial/PlaybackKeyPair/identity/basic (21.92s)
        --- PASS: TestAccIVS_serial/PlaybackKeyPair/basic (14.65s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ivs        211.756s

This annotation can be used for acceptance tests which require an ECDSA public key PEM value for a required argument.

Add resource identity to ARN-based resources in `ivs`. This includes: `aws_ivs_channel` `aws_ivs_playback_key_pair` `aws_ivs_recording_configuration` ```console % make testacc PKG=ivs TESTS="TestAccIVSChannel|TestAccIVSRecordingConfiguration|TestAccIVS_serial/PlaybackKeyPair/" make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.24.5 test ./internal/service/ivs/... -v -count 1 -parallel 20 -run='TestAccIVSChannel|TestAccIVSRecordingConfiguration|TestAccIVS_serial/PlaybackKeyPair/' -timeout 360m -vet=off 2025/08/04 16:32:55 Creating Terraform AWS Provider (SDKv2-style)... 2025/08/04 16:32:56 Initializing Terraform AWS Provider (SDKv2-style)... --- PASS: TestAccIVSChannel_disappears (25.72s) === RUN TestAccIVS_serial/PlaybackKeyPair/update --- PASS: TestAccIVSChannel_basic (29.70s) --- PASS: TestAccIVSRecordingConfiguration_disappears_S3Bucket (38.53s) --- PASS: TestAccIVSChannel_Identity_Basic (45.48s) --- PASS: TestAccIVSRecordingConfiguration_disappears (45.81s) --- PASS: TestAccIVSChannel_recordingConfiguration (46.30s) --- PASS: TestAccIVSChannel_update (46.42s) --- PASS: TestAccIVSRecordingConfiguration_basic (49.21s) --- PASS: TestAccIVSChannel_Identity_RegionOverride (52.01s) --- PASS: TestAccIVSChannel_tags (56.36s) --- PASS: TestAccIVSRecordingConfiguration_Identity_RegionOverride (56.58s) --- PASS: TestAccIVSChannel_Identity_ExistingResource (60.47s) === RUN TestAccIVS_serial/PlaybackKeyPair/tags --- PASS: TestAccIVSRecordingConfiguration_Identity_Basic (61.72s) --- PASS: TestAccIVSRecordingConfiguration_update (64.36s) --- PASS: TestAccIVSRecordingConfiguration_Identity_ExistingResource (69.30s) --- PASS: TestAccIVSRecordingConfiguration_tags (77.87s) === RUN TestAccIVS_serial/PlaybackKeyPair/disappears === RUN TestAccIVS_serial/PlaybackKeyPair/identity === RUN TestAccIVS_serial/PlaybackKeyPair/identity/basic === RUN TestAccIVS_serial/PlaybackKeyPair/identity/ExistingResource === RUN TestAccIVS_serial/PlaybackKeyPair/identity/RegionOverride --- PASS: TestAccIVS_serial (198.39s) --- PASS: TestAccIVS_serial/PlaybackKeyPair (198.39s) --- PASS: TestAccIVS_serial/PlaybackKeyPair/basic (29.36s) --- PASS: TestAccIVS_serial/PlaybackKeyPair/update (31.69s) --- PASS: TestAccIVS_serial/PlaybackKeyPair/tags (35.14s) --- PASS: TestAccIVS_serial/PlaybackKeyPair/disappears (12.56s) --- PASS: TestAccIVS_serial/PlaybackKeyPair/identity (89.64s) --- PASS: TestAccIVS_serial/PlaybackKeyPair/identity/basic (22.38s) --- PASS: TestAccIVS_serial/PlaybackKeyPair/identity/ExistingResource (41.32s) --- PASS: TestAccIVS_serial/PlaybackKeyPair/identity/RegionOverride (25.94s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ivs 204.684s ```

…emplate

```console % make testacc PKG=ivs TESTS="TestAccIVSChannel|TestAccIVSRecordingConfiguration|TestAccIVS_serial/PlaybackKeyPair/" make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.24.5 test ./internal/service/ivs/... -v -count 1 -parallel 20 -run='TestAccIVSChannel|TestAccIVSRecordingConfiguration|TestAccIVS_serial/PlaybackKeyPair/' -timeout 360m -vet=off 2025/08/06 14:57:32 Creating Terraform AWS Provider (SDKv2-style)... 2025/08/06 14:57:32 Initializing Terraform AWS Provider (SDKv2-style)... --- PASS: TestAccIVSChannel_disappears (30.74s) --- PASS: TestAccIVSChannel_basic (36.99s) --- PASS: TestAccIVSRecordingConfiguration_disappears (43.99s) --- PASS: TestAccIVSRecordingConfiguration_disappears_S3Bucket (44.98s) === RUN TestAccIVS_serial/PlaybackKeyPair/tags --- PASS: TestAccIVSChannel_recordingConfiguration (52.33s) --- PASS: TestAccIVSRecordingConfiguration_basic (52.52s) --- PASS: TestAccIVSChannel_Identity_Basic (55.28s) --- PASS: TestAccIVSChannel_update (55.33s) --- PASS: TestAccIVSChannel_Identity_RegionOverride (61.16s) --- PASS: TestAccIVSRecordingConfiguration_Identity_RegionOverride (63.90s) --- PASS: TestAccIVSChannel_tags (66.40s) --- PASS: TestAccIVSRecordingConfiguration_Identity_Basic (69.27s) --- PASS: TestAccIVSChannel_Identity_ExistingResource (69.83s) --- PASS: TestAccIVSRecordingConfiguration_update (74.72s) --- PASS: TestAccIVSRecordingConfiguration_Identity_ExistingResource (74.75s) --- PASS: TestAccIVSRecordingConfiguration_tags (84.18s) === RUN TestAccIVS_serial/PlaybackKeyPair/disappears === RUN TestAccIVS_serial/PlaybackKeyPair/identity === RUN TestAccIVS_serial/PlaybackKeyPair/identity/ExistingResource === RUN TestAccIVS_serial/PlaybackKeyPair/identity/RegionOverride === RUN TestAccIVS_serial/PlaybackKeyPair/identity/basic === RUN TestAccIVS_serial/PlaybackKeyPair/basic --- PASS: TestAccIVS_serial (205.39s) --- PASS: TestAccIVS_serial/PlaybackKeyPair (205.39s) --- PASS: TestAccIVS_serial/PlaybackKeyPair/update (45.14s) --- PASS: TestAccIVS_serial/PlaybackKeyPair/tags (43.46s) --- PASS: TestAccIVS_serial/PlaybackKeyPair/disappears (12.14s) --- PASS: TestAccIVS_serial/PlaybackKeyPair/identity (90.01s) --- PASS: TestAccIVS_serial/PlaybackKeyPair/identity/ExistingResource (41.90s) --- PASS: TestAccIVS_serial/PlaybackKeyPair/identity/RegionOverride (26.19s) --- PASS: TestAccIVS_serial/PlaybackKeyPair/identity/basic (21.92s) --- PASS: TestAccIVS_serial/PlaybackKeyPair/basic (14.65s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ivs 211.756s ```

ewbankkit

LGTM 🚀.

github-actions · 2025-08-07T15:01:50Z

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

github-actions · 2025-08-07T18:10:25Z

This functionality has been released in v6.8.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

jar-b force-pushed the f-ri-ivs branch from 1b4ea6d to 6eee591 Compare August 4, 2025 20:39

jar-b marked this pull request as ready for review August 5, 2025 00:32

jar-b requested a review from a team as a code owner August 5, 2025 00:32

gdavison reviewed Aug 6, 2025

View reviewed changes

internal/service/ivs/testdata/tmpl/recording_configuration_tags.gtpl Show resolved Hide resolved

jar-b force-pushed the f-ri-ivs branch from 106f2a4 to 2aec97a Compare August 6, 2025 19:25

github-actions bot added service/quicksight Issues and PRs that pertain to the quicksight service. service/logs Issues and PRs that pertain to the logs service. service/ivschat Issues and PRs that pertain to the ivschat service. labels Aug 6, 2025

jar-b mentioned this pull request Aug 6, 2025

Run make gen #43743

Merged

jar-b force-pushed the f-ri-ivs branch from 9f62475 to 03adf7e Compare August 6, 2025 20:31

jar-b added 5 commits August 7, 2025 09:51

internal/generate: add @Testing(tlsEcdsaPublicKeyPem) annotation

881062a

This annotation can be used for acceptance tests which require an ECDSA public key PEM value for a required argument.

r/aws_ivs_recording_configuration: properly order resources in test t…

b3be718

…emplate

r/aws_ivs: re-generate identity tests after rebase

ec4b667

jar-b force-pushed the f-ri-ivs branch from 03adf7e to ec4b667 Compare August 7, 2025 13:52

ewbankkit approved these changes Aug 7, 2025

View reviewed changes

ewbankkit added the resource-identity Pertains to resource identity. label Aug 7, 2025

jar-b merged commit 77a78ce into main Aug 7, 2025
65 checks passed

jar-b deleted the f-ri-ivs branch August 7, 2025 15:01

github-actions bot added this to the v6.8.0 milestone Aug 7, 2025

github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add ARN-based resource identity to `ivs` #43704

Add ARN-based resource identity to `ivs` #43704

Uh oh!

jar-b commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

gdavison left a comment

Uh oh!

Uh oh!

jar-b commented Aug 6, 2025

Uh oh!

ewbankkit left a comment

Uh oh!

Uh oh!

github-actions bot commented Aug 7, 2025

Uh oh!

github-actions bot commented Aug 7, 2025

Uh oh!

Uh oh!

Add ARN-based resource identity to ivs #43704

Add ARN-based resource identity to ivs #43704

Uh oh!

Conversation

jar-b commented Aug 4, 2025

Rollback Plan

Changes to Security Controls

Description

Relations

Output from Acceptance Testing

Uh oh!

github-actions bot commented Aug 4, 2025

Community Guidelines

Voting for Prioritization

Pull Request Authors

Uh oh!

gdavison left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jar-b commented Aug 6, 2025

Uh oh!

ewbankkit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Aug 7, 2025

Uh oh!

github-actions bot commented Aug 7, 2025

Uh oh!

Uh oh!

Add ARN-based resource identity to `ivs` #43704

Add ARN-based resource identity to `ivs` #43704