HHH-19673 hibernate-gradle-plugin 7.0.0.CR1 wrongly requires Java 21+ #10677
+13
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ules to hibernate-gradle-plugin Otherwise the Java requirement on release will be whatever we use on CI, which currently is Java 21...
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a Java version compatibility issue in the hibernate-gradle-plugin where it was incorrectly requiring Java 21+ instead of supporting Java 17. The fix involves changing the plugin reference from local.module to local.java-module to ensure proper bytecode version handling for compiled class files.
- Changes the Gradle plugin ID to use the correct module plugin that handles Java bytecode versioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-19673
It seems this one-liner does the trick for the bytecode version of compiled class files (obviously, since that's handled by the
java-moduleplugin). I'm hoping this is all Gradle needs to accept using a module in a project using Java 17.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.