Skip to content

HHH-19673 hibernate-gradle-plugin 7.0.0.CR1 wrongly requires Java 21+ #10677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ plugins {
id "local.java-module"
}

def skipJacoco = project.hasProperty('skipJacoco') ? project.getProperty('skipJacoco').toBoolean() : false
if (!skipJacoco) {
plugins.apply('jacoco')
}

description = 'Integration tests for running Hibernate ORM in the Java module path'

// See https://docs.gradle.org/6.7.1/userguide/java_testing.html#blackbox_integration_testing
Expand Down
5 changes: 0 additions & 5 deletions local-build-plugins/src/main/groovy/local.java-module.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,6 @@ def jpaVersion = ormBuildDetails.jpaVersion
def java9ModuleNameBase = project.name.startsWith( 'hibernate-' ) ? name.drop( 'hibernate-'.length() ): name
def java9ModuleName = "org.hibernate.orm.$java9ModuleNameBase".replace('-','.')

def skipJacoco = project.hasProperty('skipJacoco') ? project.getProperty('skipJacoco').toBoolean() : false
if (!skipJacoco) {
plugins.apply('jacoco')
}

sourceSets {
test {
resources {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@ plugins {
id "local.code-quality"
}

// Ideally this should be in `local.java-module.gradle`,
// but we need to skip this in hibernate-gradle-plugin.
def skipJacoco = project.hasProperty('skipJacoco') ? project.getProperty('skipJacoco').toBoolean() : false
if (!skipJacoco) {
plugins.apply('jacoco')
}

configurations {
javadocSources {
description = "All Java sources for the project's Javadoc"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import org.apache.tools.ant.filters.ReplaceTokens

plugins {
id 'java-gradle-plugin'
id "local.module"
id "local.java-module"
id "local.javadoc"
id "local.code-quality"

Expand Down