fix: missing implementation groups on exports

[Axxiar]

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of implementation group selection in compliance assessments, ensuring that all group names are shown when no specific groups are selected but groups are defined in the framework.

[coderabbitai]

Walkthrough

The get_selected_implementation_groups method in the ComplianceAssessment class was updated to refine how it determines the list of selected implementation groups. The revised logic now explicitly handles three scenarios based on the presence of the framework's implementation group definitions and the assessment's selected groups. If neither is set, it returns an empty list; if only the framework defines groups, it returns all group names; otherwise, it returns only those groups that are both defined and selected. The method signature remains unchanged.

Changes

File(s)	Change Summary
backend/core/models.py	Updated ComplianceAssessment.get_selected_implementation_groups method logic for clearer, more precise handling of group selection scenarios.

Poem

In the warren of code, a method refined,
Now groups are selected with logic aligned.
If none are chosen, all groups hop in—
If none exist, the list is thin.
With clarity bright, the code now sings,
A rabbit’s delight in the simplest things! 🐇

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 418daac and 4834329.

📒 Files selected for processing (1)

• backend/core/models.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: enterprise-startup-docker-compose-test
• GitHub Check: startup-functional-test (3.12)
• GitHub Check: startup-docker-compose-test
• GitHub Check: functional-tests (3.12, chromium)
• GitHub Check: test (3.12)
• GitHub Check: enterprise-startup-functional-test (3.12)
• GitHub Check: build (3.12)
• GitHub Check: enterprise-functional-tests (3.12, chromium)

🔇 Additional comments (1)

backend/core/models.py (1)

3214-3227: Improved implementation group handling logic

This change enhances the get_selected_implementation_groups method by properly handling all possible scenarios for framework implementation groups and assessment selections. The new logic correctly returns:

• An empty list when both definitions and selections are empty
• All group names when no specific groups are selected but definitions exist
• Only matching groups when specific selections are made

This solves the issue where exports would have missing implementation groups when none were specifically selected but the framework defined groups.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[eric-intuitem]

Perhaps there is a misunderstanding. When no IG is selected, the "IG" functionality is not used, so we use all requirements, regardless of IG. We don't need to list IGs in this situation, because we don't care for them.
I think this is the current behaviour, so probably no need to change.