Skip to content

fix: missing implementation groups on exports #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: missing implementation groups on exports #1851

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f41cbda
added missing implem groups when empty on html report
Axxiar Apr 14, 2025
418daac
added missing implem groups when empty on word report
Axxiar Apr 14, 2025
d5e29df
refactor get_selected_implementation_groups
Axxiar Apr 15, 2025
4834329
clean previous change
Axxiar Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions backend/core/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3212,15 +3212,18 @@ def get_global_score(self):

def get_selected_implementation_groups(self):
framework = self.framework
if (
not framework.implementation_groups_definition
or not self.selected_implementation_groups
):
igs_definition = framework.implementation_groups_definition
selected_ig = self.selected_implementation_groups

if not igs_definition and not selected_ig:
return []

if not selected_ig: # no selected_ig but some ig_definition -> means nothing is selected so we want every ig
return [group.get("name") for group in igs_definition]
return [
group.get("name")
for group in framework.implementation_groups_definition
if group.get("ref_id") in self.selected_implementation_groups
for group in igs_definition
if group.get("ref_id") in selected_ig
]

def get_requirement_assessments(self, include_non_assessable: bool):
Expand Down
Loading