Skip to content

Allow selecting articulation root prim explicitly #2228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lgulich
Copy link
Contributor

@lgulich lgulich commented Apr 2, 2025

Description

Normally the Articulation class would search for an articulation root below ArticulationCfg.prim_path. However this fails when multiple articulation roots are present. This PR allows to explicitly specify an articulation root prim path with ArticulationCfg.articulation_root_prim_path. If not set it will fall back to the old search approach.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@lgulich lgulich force-pushed the lgulich/allow-selecting-articulation-root-prim branch from 7bb0ae0 to 8c785a4 Compare April 15, 2025 08:04
@jtigue-bdai
Copy link
Collaborator

jtigue-bdai commented Apr 29, 2025

In your use case, are you importing a USD with multiple robots? If so I don't think the Articulation root_physx_view will initialize for a multirobot setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants