[12.x] Pipeline::withinTransaction() accepts connection #56550
Merged
+50
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
|
@taylorotwell Might we consider revising the name of this method? It does not wrap each step in a separate transaction, it wraps all steps in a single transaction. |
|
Hey @cosmastech! I renamed the method. Can you update this PR with the upstream changes? |
cosmastech
changed the title
cosmastech
force-pushed
the
pipeline-accepts-connection
branch
from
a9e28b1 to
c1ba842
Compare
cosmastech
force-pushed
the
pipeline-accepts-connection
branch
from
c1ba842 to
db9e555
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the request here to accept a connection.