Add windows-amd and windows-nvidia GitHub workflows for the two new machines #313
Conversation
|
The duplication here concerns me. Why can we use a matrix for the PR jobs, but not the others? |
IIRC, @llvm-beanz said it was to have individual badges / status icons for each job. |
|
I'm not sure we need to duplicate the WARP workflows though. Wouldn't the WARP test result be expected to be the same across all machines? We could designate just one machine to running the WARP tests. |
Ah, I see, that's an unfortunate limitation from github. But it does remind me that you should also update README.md to reference these badges. |
They'd certainly be expected to have the same results. As the same time, if they gave different results then that'd be good to know! |
Maybe could consider a consolidated WARP workflow that runs on all the machines? |
I think if we wanted to run the WARP tests on different underlying hardware we should do that only in the periodic builds not the pre-merge builds. We could alternatively just allow the WARP scheduled builds to use any windows builder which will cycle it through based on machine availability. That might be good enough to provide some coverage without slowing down our builds too much. |
This reverts commit e83e76f.
docs/BuildMachineInfo.md
Outdated
| * CPU: Intel Xeon <I'll figure out the model> | ||
| * GPU: Intel UHD Graphics 630 | ||
| * RAM: <I should figure this out too> |
There was a problem hiding this comment.
Waiting on @llvm-beanz to provide the specs for the intel machine.
There was a problem hiding this comment.
I'm having trouble remoting into the machine. Can you just leave blank lines? I'll hunt it down and update after this PR merges.
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| SKU: [windows-amd] |
There was a problem hiding this comment.
I'm not sure how to pick a SKU randomly or based on availability, so I picked the AMD machine because it has the better CPU and the most RAM to work with between the NVIDIA and AMD machines.
I'm not sure yet what the specs of the Intel machine are, nor if we would would want to keep running the Warp tests on it because it's not a lab machine.
There was a problem hiding this comment.
This seems reasonable. The Intel machine I have is old and slow, so doing less on it is probably good.
There's a lot of red :( |
These machines currently have execution test failures that need to be resolved before they can be part of PR pre-merge checks.
This PR duplicates the existing windows-intel github workflows to support the new windows-amd and windows-nvidia machines.
windows-amd and windows-nvidia have also been added to the pr-matrix workflow SKUs for the Exec-Tests-Windows job.
The WARP workflow has been changed to run solely on the AMD machine only.