-
Notifications
You must be signed in to change notification settings - Fork 18
Add windows-amd and windows-nvidia GitHub workflows for the two new machines #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+210
−7
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
63612e5
Add windows-amd and windows-nvidia GitHub workflows
Icohedron 639b6db
Update README.md to include the new AMD and NVIDIA badges
Icohedron e83e76f
Consolidate all WARP tests under one matrix workflow
Icohedron 403958c
Revert "Consolidate all WARP tests under one matrix workflow"
Icohedron ab263c3
Add a doc for build machine information
Icohedron 2db080e
Run Warp exec test on AMD machine only
Icohedron 94377da
Update SKU choices
Icohedron 2b44052
Blank unknown intel machine specifications
Icohedron 3c5306b
Change Windows DirectX12 Warp badge to use result from AMD machine
Icohedron fec7d79
Do not schedule intel and nvidia warp builds
Icohedron b464a4c
Remove intel and nvidia warp workflows
Icohedron 1f36fa5
Remove AMD and NVIDIA SKUs from the pre-merge checks
Icohedron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| name: Windows D3D12 AMD Clang | ||
|
|
||
| permissions: | ||
| contents: read | ||
| checks: write | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| schedule: | ||
| - cron: '0 */2 * * *' # run every 2 hours | ||
|
|
||
| jobs: | ||
| Windows-D3D12-AMD-Clang: | ||
| uses: ./.github/workflows/build-and-test-callable.yaml | ||
| with: | ||
| OS: windows | ||
| SKU: windows-amd | ||
| TestTarget: check-hlsl-clang-d3d12 | ||
| OffloadTest-branch: ${{ github.ref }} | ||
| LLVM-ExtraCMakeArgs: -DCMAKE_C_COMPILER=clang-cl -DCMAKE_CXX_COMPILER=clang-cl -DOFFLOADTEST_USE_CLANG_TIDY=On |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| name: Windows Vulkan AMD Clang | ||
|
|
||
| permissions: | ||
| contents: read | ||
| checks: write | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| schedule: | ||
| - cron: '0 */2 * * *' # run every 2 hours | ||
|
|
||
| jobs: | ||
| Windows-VK-AMD-Clang: | ||
| uses: ./.github/workflows/build-and-test-callable.yaml | ||
| with: | ||
| OS: windows | ||
| SKU: windows-amd | ||
| TestTarget: check-hlsl-clang-vk | ||
| OffloadTest-branch: ${{ github.ref }} | ||
| LLVM-ExtraCMakeArgs: -DCMAKE_C_COMPILER=clang-cl -DCMAKE_CXX_COMPILER=clang-cl -DOFFLOADTEST_USE_CLANG_TIDY=On |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| name: Windows D3D12 AMD DXC | ||
|
|
||
| permissions: | ||
| contents: read | ||
| checks: write | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| schedule: | ||
| - cron: '0 * * * *' # run every 30 minutes | ||
|
|
||
| jobs: | ||
| Windows-D3D12-AMD-DXC: | ||
| uses: ./.github/workflows/build-and-test-callable.yaml | ||
| with: | ||
| OS: windows | ||
| SKU: windows-amd | ||
| BuildType: Debug | ||
| TestTarget: check-hlsl-d3d12 | ||
| OffloadTest-branch: ${{ github.ref }} | ||
| LLVM-ExtraCMakeArgs: -DCMAKE_C_COMPILER=clang-cl -DCMAKE_CXX_COMPILER=clang-cl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| name: Windows Vulkan AMD DXC | ||
|
|
||
| permissions: | ||
| contents: read | ||
| checks: write | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| schedule: | ||
| - cron: '0 */2 * * *' # run every 2 hours | ||
|
|
||
| jobs: | ||
| Windows-VK-AMD-DXC: | ||
| uses: ./.github/workflows/build-and-test-callable.yaml | ||
| with: | ||
| OS: windows | ||
| SKU: windows-amd | ||
| BuildType: Debug | ||
| TestTarget: check-hlsl-vk | ||
| OffloadTest-branch: ${{ github.ref }} | ||
| LLVM-ExtraCMakeArgs: -DCMAKE_C_COMPILER=clang-cl -DCMAKE_CXX_COMPILER=clang-cl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| name: Windows D3D12 NVIDIA Clang | ||
|
|
||
| permissions: | ||
| contents: read | ||
| checks: write | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| schedule: | ||
| - cron: '0 */2 * * *' # run every 2 hours | ||
|
|
||
| jobs: | ||
| Windows-D3D12-NVIDIA-Clang: | ||
| uses: ./.github/workflows/build-and-test-callable.yaml | ||
| with: | ||
| OS: windows | ||
| SKU: windows-nvidia | ||
| TestTarget: check-hlsl-clang-d3d12 | ||
| OffloadTest-branch: ${{ github.ref }} | ||
| LLVM-ExtraCMakeArgs: -DCMAKE_C_COMPILER=clang-cl -DCMAKE_CXX_COMPILER=clang-cl -DOFFLOADTEST_USE_CLANG_TIDY=On |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| name: Windows Vulkan NVIDIA Clang | ||
|
|
||
| permissions: | ||
| contents: read | ||
| checks: write | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| schedule: | ||
| - cron: '0 */2 * * *' # run every 2 hours | ||
|
|
||
| jobs: | ||
| Windows-VK-NVIDIA-Clang: | ||
| uses: ./.github/workflows/build-and-test-callable.yaml | ||
| with: | ||
| OS: windows | ||
| SKU: windows-nvidia | ||
| TestTarget: check-hlsl-clang-vk | ||
| OffloadTest-branch: ${{ github.ref }} | ||
| LLVM-ExtraCMakeArgs: -DCMAKE_C_COMPILER=clang-cl -DCMAKE_CXX_COMPILER=clang-cl -DOFFLOADTEST_USE_CLANG_TIDY=On |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| name: Windows D3D12 NVIDIA DXC | ||
Icohedron marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| permissions: | ||
| contents: read | ||
| checks: write | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| schedule: | ||
| - cron: '0 * * * *' # run every 30 minutes | ||
|
|
||
| jobs: | ||
| Windows-D3D12-NVIDIA-DXC: | ||
| uses: ./.github/workflows/build-and-test-callable.yaml | ||
| with: | ||
| OS: windows | ||
| SKU: windows-nvidia | ||
| BuildType: Debug | ||
| TestTarget: check-hlsl-d3d12 | ||
| OffloadTest-branch: ${{ github.ref }} | ||
| LLVM-ExtraCMakeArgs: -DCMAKE_C_COMPILER=clang-cl -DCMAKE_CXX_COMPILER=clang-cl | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| name: Windows Vulkan NVIDIA DXC | ||
|
|
||
| permissions: | ||
| contents: read | ||
| checks: write | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| schedule: | ||
| - cron: '0 */2 * * *' # run every 2 hours | ||
|
|
||
| jobs: | ||
| Windows-VK-NVIDIA-DXC: | ||
| uses: ./.github/workflows/build-and-test-callable.yaml | ||
| with: | ||
| OS: windows | ||
| SKU: windows-nvidia | ||
| BuildType: Debug | ||
| TestTarget: check-hlsl-vk | ||
| OffloadTest-branch: ${{ github.ref }} | ||
| LLVM-ExtraCMakeArgs: -DCMAKE_C_COMPILER=clang-cl -DCMAKE_CXX_COMPILER=clang-cl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # Build Machine Information | ||
|
|
||
| ## Windows AMD GPU | ||
|
|
||
| * CPU: AMD Ryzen 7 9700X | ||
| * GPU: AMD Radeon RX 9070 | ||
| * RAM: 32 GiB | ||
|
|
||
| ## Windows Intel GPU | ||
|
|
||
| * CPU: | ||
| * GPU: Intel UHD Graphics 630 | ||
| * RAM: | ||
|
|
||
| ## Windows NVIDIA GPU | ||
|
|
||
| * CPU: Intel(R) Core(TM) i5-14400F | ||
| * GPU: NVIDIA GeForce RTX 5070 | ||
| * RAM: 16 GiB |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how to pick a SKU randomly or based on availability, so I picked the AMD machine because it has the better CPU and the most RAM to work with between the NVIDIA and AMD machines.
I'm not sure yet what the specs of the Intel machine are, nor if we would would want to keep running the Warp tests on it because it's not a lab machine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable. The Intel machine I have is old and slow, so doing less on it is probably good.