-
Notifications
You must be signed in to change notification settings - Fork 372
Added Email button to working groups page #2776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for working on this. The screenshot looks great, the code looks reasonable.
- Please provide the source of the email icon. Usually, media assets do not use code licenses.
- I have edited your description to follow this syntax so we make sure the issue gets closed: https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
- Please ensure your editor follows the repo's .editorconfig, in this case following the linux convention of newlines at the end of files.
Thank you for your feedback and the helpful suggestions!
|
Thank you. For reference, here is a link confirming that material icons are indeed licensed Apache 2.0: https://developers.google.com/fonts/docs/material_symbols#licensing We need to find a way to include the original copyright notice along with the file to respect the license. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find a copyright notice. Also not on https://github.com/google/material-design-icons. It seems Google does not understand how to open source.
@thibaultamartin how do you think should we proceed?
Co-authored-by: Kim Brose <[email protected]>
Resolves #2774

Added Email button to he working groups page (matrix.org/templates/governing-board/working_groups.html), appearing after the Matrix button.
License: Apache License 2.0