Skip to content

ESC Status Toolbar #13191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

ESC Status Toolbar #13191

wants to merge 17 commits into from

Conversation

dakejahl
Copy link
Contributor

@dakejahl dakejahl commented Jul 20, 2025

Toolbar icon for ESC status. Requires reception of ESC_INFO and ESC_STATUS mavlink messages.

TODO

  • clean up messy claude logic in qml code
  • any way to have a vector/array of facts instead of first/second/third/etc naming?
  • test with 8 motors
  • add RPM to Ardupilot MotorComponent
  • test with Ardupilot

Closes #12947

image image

@Davidsastresas
Copy link
Member

Thanks Jake, I will try to take a look at it this week

@Davidsastresas
Copy link
Member

About the vector thing, I think if you check how batteryfactgroup is done we could do something similar maybe here

@DonLakeFlyer
Copy link
Contributor

About the vector thing, I think if you check how batteryfactgroup is done we could do something similar maybe here

Yup

@DonLakeFlyer
Copy link
Contributor

@dakejahl Can you add screenshots?

@dakejahl
Copy link
Contributor Author

Added screenshots to the PR description

@dakejahl
Copy link
Contributor Author

The "max temp" and "max current" are just what QGC has seen... I'm not sure if it's that useful. If we cared about max values the FC should report that explicitly.

@DonLakeFlyer
Copy link
Contributor

@dakejahl Do you mind if I take over the ESC_STATUS and ESC_INFO telemetry handling part of this? I'd like to create a generic FactGroup list mechanism which will handle multiples. The battery FactGroup code already has most of what is needed, it's just not done in a fully generic way. If so, just sit on this for a bit and I'll create the telemetry backend for all of it. Then you can adjust the rest to that.

@dakejahl
Copy link
Contributor Author

I would love if you did that! Thank you! I will rework this as needed once you have the backend implemented

@dakejahl dakejahl force-pushed the pr-esc_status branch 2 times, most recently from b1b536f to d4a2ac7 Compare July 31, 2025 07:31
@dakejahl
Copy link
Contributor Author

dakejahl commented Aug 4, 2025

I've also got a PR here for adding a new mavlink message ESC_EEPROM. This would just be an array of uint8.
https://github.com/mavlink/mavlink/pull/2324/files

Similar to BatteryFactGroup should I just use a uint8 pointer Fact and allocate an array?

@DonLakeFlyer
Copy link
Contributor

Sorry for the delay, I was out of town. I'll get this done by end of day today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESC health, RPM, temperature reporting
3 participants