-
Notifications
You must be signed in to change notification settings - Fork 4.2k
ESC Status Toolbar #13191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
ESC Status Toolbar #13191
Conversation
Thanks Jake, I will try to take a look at it this week |
About the vector thing, I think if you check how batteryfactgroup is done we could do something similar maybe here |
Yup |
@dakejahl Can you add screenshots? |
Added screenshots to the PR description |
The "max temp" and "max current" are just what QGC has seen... I'm not sure if it's that useful. If we cared about max values the FC should report that explicitly. |
@dakejahl Do you mind if I take over the ESC_STATUS and ESC_INFO telemetry handling part of this? I'd like to create a generic FactGroup list mechanism which will handle multiples. The battery FactGroup code already has most of what is needed, it's just not done in a fully generic way. If so, just sit on this for a bit and I'll create the telemetry backend for all of it. Then you can adjust the rest to that. |
I would love if you did that! Thank you! I will rework this as needed once you have the backend implemented |
b1b536f
to
d4a2ac7
Compare
I've also got a PR here for adding a new mavlink message ESC_EEPROM. This would just be an array of uint8. Similar to BatteryFactGroup should I just use a uint8 pointer Fact and allocate an array? |
Sorry for the delay, I was out of town. I'll get this done by end of day today. |
Toolbar icon for ESC status. Requires reception of ESC_INFO and ESC_STATUS mavlink messages.
TODO
Closes #12947