perf(drizzle): single-roundtrip db updates for simple collections #13186
+402
−346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖 |
r1tsuu
requested changes
Jul 17, 2025
Comment on lines
+73
to
+80
| if (!Object.keys(findManyArgs).length) { | ||
| // Optimization - No need for joins => can simply use returning(). This is optimal for very simple collections | ||
| // without complex fields that live in separate tables like blocks, arrays, relationships, etc. | ||
| const docs = await drizzle | ||
| .update(adapter.tables[tableName]) | ||
| .set(row) | ||
| .where(eq(adapter.tables[tableName].id, id)) | ||
| .returning() |
There was a problem hiding this comment.
What if select is passed? Then findManyArgs here should have the columns key and this condition wouldn't pass, even though it's still a "simple" query. We should handle it instead in returning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be reviewed after #13184 is merged.
Currently, an optimized DB update (simple data => no delete-and-create-row) does the following:
This PR reduces this further to one single DB call for simple collections:
This only works for simple collections that do not have any fields that need to be fetched from other tables. If a collection has fields like relationship or blocks, we'll need that separate SELECT call to join in the other tables.
In 4.0, we can remove all "complex" fields from the jobs collection and replace them with a JSON field to make use of this optimization