-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
[Model] Add Ling implementation #20680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: vito.yy <[email protected]>
Signed-off-by: vito.yy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @ant-yy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces comprehensive support for the Ling Mixture-of-Experts (MoE) language model series within the vLLM framework. This integration allows vLLM users to leverage Ling's efficient inference capabilities, including its scalable MoE architecture, while benefiting from vLLM's high-throughput serving optimizations.
Highlights
- New Model Implementation: I've added the full architectural implementation for the Ling Mixture-of-Experts (MoE) model, including its attention, MLP, and MoE layers, specifically designed for efficient inference within vLLM.
- MoE Specifics: The implementation incorporates the Ling MoE architecture, handling multiple experts, shared experts, and routing logic, leveraging vLLM's
FusedMoE
layer for optimized performance. - Configuration Integration: A dedicated
BailingMoeConfig
class has been introduced to define the specific parameters and architecture of the Ling MoE models, ensuring proper model loading and configuration within the vLLM framework. - Framework Compatibility: The new Ling model integrates seamlessly with vLLM's existing infrastructure, supporting tensor and pipeline parallelism, LoRA, and the standard weight loading mechanisms.
- Documentation & Testing: The Ling model has been added to the supported models documentation and included in the test registry for automated validation and future reference.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for the Ling MoE model series. The implementation is well-structured and follows vLLM's patterns for adding new models.
I've identified a critical issue regarding a potential architectural deviation in the BailingMoeBlock
implementation compared to the original model, which could impact correctness. Please clarify if this architectural change is intentional and has been validated? If not, I strongly recommend refactoring this block to align with the original model's architecture to ensure correctness.
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nit comments
…ights to BailingMoeModel Signed-off-by: vito.yy <[email protected]>
Signed-off-by: vito.yy <[email protected]>
Signed-off-by: vito.yy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After fixing the CI failure and deleting KVCache
, overall LGTM. Thank you for your contributon, also cc @Isotr0py
Signed-off-by: vito.yy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now!
Please merge from main to fix the Async test. Also you need to fix the models test |
I need to pass the async test.
Signed-off-by: vito.yy <[email protected]>
Head branch was pushed to by a user without write access
Signed-off-by: vito.yy <[email protected]>
Signed-off-by: vito.yy <[email protected]>
Signed-off-by: vito.yy <[email protected]>
Signed-off-by: vito.yy <[email protected]> Signed-off-by: Patrick von Platen <[email protected]>
Essential Elements of an Effective PR Description Checklist
Purpose
Add [Model] Ling implementation
This PR adds support for the Ling Mixture-of-Experts (MoE) language model series open-sourced by InclusionAI (GitHub). The implementation includes:
Key features:
The implementation follows vLLM's model integration patterns and maintains compatibility with existing serving infrastructure. This addition will allow vLLM users to leverage Ling's efficient inference capabilities while benefiting from the framework's high-throughput serving optimizations.
Ling
Test Plan
We will conduct the following datasets tests in subsequent phases, and the results will be supplemented accordingly:
Datasets to be evaluated: MMLU(EM), GPQA(Pass@1), HumanEval(Pass@1), LiveCodeBench 2408-2502 (Pass@1), LCBench(pass@1), Math(EM), AIME2024(pass@1), OlympiadBench(pass@1), BBH(EM), IFEval(Prompt Strict), BFCL_live1.
Test Result
Here are the results based on vLLM 0.7.3.