Skip to content

fixed redundant defer in sessionCore.closeOnce #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2025
Merged

Conversation

asmyasnikov
Copy link
Member

No description provided.

Copy link

github-actions bot commented Jun 21, 2025

summary

Base version: v3.111.3 (master)
Suggested version: v3.111.4

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.69%. Comparing base (0d167dd) to head (048b8cb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1817      +/-   ##
==========================================
- Coverage   70.81%   70.69%   -0.13%     
==========================================
  Files         386      386              
  Lines       40234    40234              
==========================================
- Hits        28492    28442      -50     
- Misses      10575    10612      +37     
- Partials     1167     1180      +13     
Flag Coverage Δ
experiment 70.26% <100.00%> (-0.21%) ⬇️
go-1.21.x 68.37% <100.00%> (-0.09%) ⬇️
go-1.24.x 70.65% <100.00%> (-0.17%) ⬇️
integration 53.45% <100.00%> (-0.48%) ⬇️
macOS 40.41% <100.00%> (-0.02%) ⬇️
ubuntu 70.68% <100.00%> (-0.13%) ⬇️
unit 40.41% <100.00%> (-0.02%) ⬇️
windows 40.39% <100.00%> (-0.03%) ⬇️
ydb-24.4 52.54% <100.00%> (-0.62%) ⬇️
ydb-25.1 53.36% <100.00%> (-0.51%) ⬇️
ydb-latest 52.96% <100.00%> (-0.54%) ⬇️
ydb-nightly 70.26% <100.00%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@asmyasnikov asmyasnikov requested a review from kprokopenko July 1, 2025 11:10
Copy link

github-actions bot commented Jul 1, 2025

Metrics

Success Rate

Success Rate

Operations Per Second

Operations Per Second

95th Percentile Latency

95th Percentile Latency

8 similar comments
Copy link

github-actions bot commented Jul 1, 2025

Metrics

Success Rate

Success Rate

Operations Per Second

Operations Per Second

95th Percentile Latency

95th Percentile Latency

Copy link

github-actions bot commented Jul 1, 2025

Metrics

Success Rate

Success Rate

Operations Per Second

Operations Per Second

95th Percentile Latency

95th Percentile Latency

Copy link

github-actions bot commented Jul 1, 2025

Metrics

Success Rate

Success Rate

Operations Per Second

Operations Per Second

95th Percentile Latency

95th Percentile Latency

Copy link

github-actions bot commented Jul 1, 2025

Metrics

Success Rate

Success Rate

Operations Per Second

Operations Per Second

95th Percentile Latency

95th Percentile Latency

Copy link

github-actions bot commented Jul 1, 2025

Metrics

Success Rate

Success Rate

Operations Per Second

Operations Per Second

95th Percentile Latency

95th Percentile Latency

Copy link

github-actions bot commented Jul 1, 2025

Metrics

Success Rate

Success Rate

Operations Per Second

Operations Per Second

95th Percentile Latency

95th Percentile Latency

Copy link

github-actions bot commented Jul 1, 2025

Metrics

Success Rate

Success Rate

Operations Per Second

Operations Per Second

95th Percentile Latency

95th Percentile Latency

Copy link

github-actions bot commented Jul 1, 2025

Metrics

Success Rate

Success Rate

Operations Per Second

Operations Per Second

95th Percentile Latency

95th Percentile Latency

@asmyasnikov asmyasnikov merged commit 333e663 into master Jul 6, 2025
43 checks passed
@asmyasnikov asmyasnikov deleted the close-once-defer branch July 6, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants