drivers: pwm: introduce ti_am3352_ecap #88860
Open
+388
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natto1784
force-pushed
the
ecap
branch
3 times, most recently
from
d7eee0f to
90ca724
Compare
github-actions
bot
added
area: PWM
github-actions
bot
requested review from
anangl,
henrikbrixandersen,
vaishnavachath and
vanti
This patch adds driver support for TI ECAP module which can capture an external input or work as a standalone APWM generator. Signed-off-by: Amneesh Singh <[email protected]>
|
CC: @gramsay0 @Ayush1325 @glneo - Please feel free to review if and when you get some time. |
Ayush1325
reviewed
May 28, 2025
| uint32_t pulse_cycles, pwm_flags_t flags) | ||
| { | ||
| ARG_UNUSED(channel); | ||
| struct ti_ecap_regs *regs = DEV_REGS(dev); |
There was a problem hiding this comment.
Maybe this should be volatile?
I know it is not used in many other drivers, but I feel like registers should use the volatile keyword.
There was a problem hiding this comment.
Individual registers all have volatile keyword in front of them in struct ti_ecap_regs
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a new PWM driver for TI ECAP modules to support both capture and APWM operations on TI SoCs.
- Added a DTS binding file for ti,am3352-ecap.
- Implemented the driver in drivers/pwm/pwm_ti_am3352_ecap.c with capture and PWM functionalities.
- Updated Kconfig and CMakeLists.txt to integrate the new driver.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| dts/bindings/pwm/ti,am3352-ecap.yaml | Added DTS binding with required properties for the new driver. |
| drivers/pwm/pwm_ti_am3352_ecap.c | New driver implementation handling both PWM and capture modes. |
| drivers/pwm/Kconfig.ti_am3352_ecap | Config file for enabling the TI ECAP based PWM controller. |
| drivers/pwm/Kconfig | Extended to include new Kconfig file for TI ECAP driver. |
| drivers/pwm/CMakeLists.txt | Updated build file to incorporate the new driver source file. |
Comments suppressed due to low confidence (2)
drivers/pwm/pwm_ti_am3352_ecap.c:119
- Casting the pointer 'cycles' from uint64_t* to uint32_t* can potentially truncate the clock rate if it exceeds 32 bits. Consider using a temporary uint32_t variable to retrieve the clock rate, then assign it to *cycles for improved clarity and type safety.
return clock_control_get_rate(cfg->clock_dev, cfg->clock_subsys, (uint32_t *)cycles);
drivers/pwm/pwm_ti_am3352_ecap.c:253
- [nitpick] The error message would be more helpful if it included the error code or additional details from the pinctrl configuration failure to assist in debugging.
LOG_ERR("Fail to configure pinctrl\n");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds driver support for TI ECAP module which can capture an external input or work as a standalone APWM generator.
Tested on AM243x EVM using loopback from EPWM (#88757)