Switch Windows build to VS2022 (v143) toolset #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows building with VS2022/v143 toolset Closes micro-manager#580.
This allows building with VS2022/v143 toolset. Closes micro-manager#578.
- `dev_Handle >= 0` was a compile error in VS2022/v143 toolset but the check was pointless because dev_Handle is not a signed integer (and probably wrong because dev_Handle is probably 0 upon failure; also dev_Handle is used before this check). - Removed a call to `USBDRVD_GetPipeCount()` whose result was never used. Closes micro-manager#579.
This was
linked to
issues
May 5, 2025
marktsuchida
force-pushed
the
vs2022-toolset
branch
from
6f02d98 to
0fbbd98
Compare
For consistency.
|
|
Rescued by an EDIT: This is probably because the JRE contains the C and C++ runtime DLLs, such as |
|
This should be good to merge after merging micro-manager/micro-manager#2100, but let's not do it today, in the interest of not changing more than one major thing in the same nightly build. (We already merged micro-manager/micro-manager#2101 today). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the required fixes for TIScam, MeadowlarkLC, and DahengGalaxy.